From: Rusty Trivial Russell <rusty@rustcorp.com.au>
To: marcelo@conectiva.com.br
Cc: viro@math.psu.edu, linux-kernel@vger.kernel.org
Subject: [TRIVIAL] silence invalidate_bdev() a bit
Date: Tue, 20 Aug 2002 18:27:52 +1000 [thread overview]
Message-ID: <20020820041035.711C72C49F@lists.samba.org> (raw)
[ Experts, does this make sense? The Debian kernel tree makes it a
KERN_DEBUG printk instead. ]
From: Christoph Hellwig <hch@lst.de>
The 2.4.1x invalidate_bdev() is a little to verbose and warns about
conditions that can easily happen in practice. Silence up those
printks a little like most vendor trees already do.
--- trivial-2.4.20-pre4/fs/buffer.c.orig 2002-08-20 18:00:33.000000000 +1000
+++ trivial-2.4.20-pre4/fs/buffer.c 2002-08-20 18:00:33.000000000 +1000
@@ -695,13 +695,13 @@
/* All buffers in the lru lists are mapped */
if (!buffer_mapped(bh))
BUG();
- if (buffer_dirty(bh))
+ if (buffer_dirty(bh) && destroy_dirty_buffers)
printk("invalidate: dirty buffer\n");
if (!atomic_read(&bh->b_count)) {
if (destroy_dirty_buffers || !buffer_dirty(bh)) {
remove_inode_queue(bh);
}
- } else
+ } else if (!bdev->bd_openers)
printk("invalidate: busy buffer\n");
write_unlock(&hash_table_lock);
--
Don't blame me: the Monkey is driving
File: Christoph Hellwig <hch@lst.de>: [PATCH] silence invalidate_bdev() a bit
reply other threads:[~2002-08-20 9:06 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020820041035.711C72C49F@lists.samba.org \
--to=rusty@rustcorp.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®