mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [TRIVIAL] silence invalidate_bdev() a bit
@ 2002-08-20  8:27 Rusty Trivial Russell
  0 siblings, 0 replies; only message in thread
From: Rusty Trivial Russell @ 2002-08-20  8:27 UTC (permalink / raw)
  To: marcelo; +Cc: viro, linux-kernel

[ Experts, does this make sense?  The Debian kernel tree makes it a
  KERN_DEBUG printk instead. ]

From:  Christoph Hellwig <hch@lst.de>

  The 2.4.1x invalidate_bdev() is a little to verbose and warns about
  conditions that can easily happen in practice.  Silence up those
  printks a little like most vendor trees already do.
  

--- trivial-2.4.20-pre4/fs/buffer.c.orig	2002-08-20 18:00:33.000000000 +1000
+++ trivial-2.4.20-pre4/fs/buffer.c	2002-08-20 18:00:33.000000000 +1000
@@ -695,13 +695,13 @@
 			/* All buffers in the lru lists are mapped */
 			if (!buffer_mapped(bh))
 				BUG();
-			if (buffer_dirty(bh))
+			if (buffer_dirty(bh) && destroy_dirty_buffers)
 				printk("invalidate: dirty buffer\n");
 			if (!atomic_read(&bh->b_count)) {
 				if (destroy_dirty_buffers || !buffer_dirty(bh)) {
 					remove_inode_queue(bh);
 				}
-			} else
+			} else if (!bdev->bd_openers)
 				printk("invalidate: busy buffer\n");
 
 			write_unlock(&hash_table_lock);
-- 
  Don't blame me: the Monkey is driving
  File: Christoph Hellwig <hch@lst.de>: [PATCH] silence invalidate_bdev() a bit

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2002-08-20  9:06 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-08-20  8:27 [TRIVIAL] silence invalidate_bdev() a bit Rusty Trivial Russell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®