From: Troy Wilson <tcw@tempest.prismnet.com>
To: Jeff Garzik <jgarzik@mandrakesoft.com>
Cc: linux-kernel@vger.kernel.org, Martin.Bligh@us.ibm.com, tcw@prismnet.com
Subject: mdelay causes BUG, please use udelay
Date: Tue, 20 Aug 2002 18:50:11 -0500 (CDT) [thread overview]
Message-ID: <200208202350.g7KNoBJG036692@tempest.prismnet.com> (raw)
In-Reply-To:
Hi Jeff,
We probably shouldn't be doing this, but we can at least avoid the BUG
caused by doing an mdelay in interrupt context if we change to udelay.
Thanks,
- Troy
diff -urN linux-2.5.31/drivers/net/e1000/e1000_hw.c linux-2.5.31.udelay/drivers/net/e1000/e1000_hw.c
--- linux-2.5.31/drivers/net/e1000/e1000_hw.c Sat Aug 10 20:41:28 2002
+++ linux-2.5.31.udelay/drivers/net/e1000/e1000_hw.c Tue Aug 20 18:12:20 2002
@@ -134,7 +134,7 @@
/* Delay to allow any outstanding PCI transactions to complete before
* resetting the device
*/
- msec_delay(10);
+ usec_delay(10000);
/* Issue a global reset to the MAC. This will reset the chip's
* transmit, receive, DMA, and link units. It will not effect
next reply other threads:[~2002-08-20 23:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-20 23:50 Troy Wilson [this message]
2002-08-21 1:00 ` Jeff Garzik
2002-08-21 0:20 Feldman, Scott
2002-08-21 0:27 ` Benjamin LaHaise
2002-08-21 0:28 ` H. Peter Anvin
2002-08-21 0:28 ` Alan Cox
2002-08-21 0:59 ` Jeff Garzik
2002-08-21 16:04 ` Martin J. Bligh
2002-08-21 16:45 ` Chris Friesen
2002-08-21 16:56 ` Martin J. Bligh
2002-08-21 17:21 ` Dave Hansen
2002-08-21 0:59 Feldman, Scott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200208202350.g7KNoBJG036692@tempest.prismnet.com \
--to=tcw@tempest.prismnet.com \
--cc=Martin.Bligh@us.ibm.com \
--cc=jgarzik@mandrakesoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tcw@prismnet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®