mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Martin J. Bligh" <Martin.Bligh@us.ibm.com>
To: "Feldman, Scott" <scott.feldman@intel.com>,
	"'Troy Wilson'" <tcw@tempest.prismnet.com>,
	Jeff Garzik <jgarzik@mandrakesoft.com>
Cc: linux-kernel@vger.kernel.org, tcw@prismnet.com
Subject: RE: mdelay causes BUG, please use udelay
Date: Wed, 21 Aug 2002 09:04:01 -0700	[thread overview]
Message-ID: <2544596606.1029920638@[10.10.2.3]> (raw)
In-Reply-To: <288F9BF66CD9D5118DF400508B68C4460283E4AF@orsmsx113.jf.intel.com>

>> -    msec_delay(10);
>> +    usec_delay(10000);
> 
> Jeff, 10000 seems on the border of what's OK.  If it's acceptable, 
> then let's go for that.  Otherwise, we're going to have to chain 
> several mod_timer callbacks together to do a controller reset.

Whilst this sort of delay in interrupt context is undoubtedly bad
any way we do it, I'd question the context a little more before we
make a decision. This is called from e1000_reset_hw - are we likely
to ever actually call this except under initialisation? If we just
do it once on system boot, I'd say evil hacks (like this) are 
acceptable. If we're going to do this under load, it definitely
needs fixing.

FWIW, this is heavily tested under Apache webserver load on a maxed 
out 8 CPU system with at least 4 (8?) gigabit ethernet cards. Whilst
undoubtedly ugly, it's better than what we have now, so might I 
suggest that we do this for now until a real fix is forthcoming if
we decide it's needed?

Martin.


  parent reply	other threads:[~2002-08-21 16:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-08-21  0:20 Feldman, Scott
2002-08-21  0:27 ` Benjamin LaHaise
2002-08-21  0:28 ` H. Peter Anvin
2002-08-21  0:28 ` Alan Cox
2002-08-21  0:59 ` Jeff Garzik
2002-08-21 16:04 ` Martin J. Bligh [this message]
2002-08-21 16:45   ` Chris Friesen
2002-08-21 16:56     ` Martin J. Bligh
2002-08-21 17:21   ` Dave Hansen
  -- strict thread matches above, loose matches on Subject: below --
2002-08-21  0:59 Feldman, Scott
2002-08-20 23:50 Troy Wilson
2002-08-21  1:00 ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='2544596606.1029920638@[10.10.2.3]' \
    --to=martin.bligh@us.ibm.com \
    --cc=jgarzik@mandrakesoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=scott.feldman@intel.com \
    --cc=tcw@prismnet.com \
    --cc=tcw@tempest.prismnet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®