From: Rusty Russell <rusty@rustcorp.com.au>
To: junkio@cox.net
Cc: linux-kernel@vger.kernel.org, Keith Owens <kaos@ocs.com.au>
Subject: Re: [TRIVIAL] strlen("literal string") -> (sizeof("literal string")-1)
Date: Thu, 29 Aug 2002 13:09:05 +1000 [thread overview]
Message-ID: <20020828221716.2C1D12C0E8@lists.samba.org> (raw)
In-Reply-To: Your message of "Wed, 28 Aug 2002 14:31:31 MST." <200208282131.g7SLVVGx024191@siamese.dyndns.org>
In message <200208282131.g7SLVVGx024191@siamese.dyndns.org> you write:
> Here is a patch that does the same as what Keith Owens did in
> his patch recently.
>
> Message-ID: <fa.iks3ohv.1flge08@ifi.uio.no>
> From: Keith Owens <kaos@ocs.com.au>
> Subject: [patch] 2.4.19 Generate better code for nfs_sillyrename
> Date: Wed, 28 Aug 2002 07:08:17 GMT
>
> Using strlen() generates an unnecessary inline function expansion plus
> dynamic stack adjustment. For constant strings, strlen() == sizeof()-1
> and the object code is better.
Disagree. If you really care make strlen use __builtin_constant_p().
Then authors don't have to sacrifice readability.
#define strlen(x) (__builtin_constant_p(x) ? sizeof(x)-1 : __strlen(x))
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
next prev parent reply other threads:[~2002-08-29 3:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <fa.iks3ohv.1flge08@ifi.uio.no>
2002-08-28 21:31 ` junkio
2002-08-28 21:55 ` Jim Treadway
2002-08-29 3:09 ` Rusty Russell [this message]
2002-08-29 3:26 ` Daniel Jacobowitz
2002-08-29 6:29 ` Rusty Russell
2002-08-29 7:10 ` Jakub Jelinek
2002-08-29 16:56 ` Linus Torvalds
2002-08-29 20:38 ` Denis Zaitsev
2002-09-06 12:53 ` Pavel Machek
[not found] <fa.lrmcokv.1q28k2s@ifi.uio.no>
[not found] ` <fa.pm2g4iv.k0s9jg@ifi.uio.no>
2002-08-29 0:49 ` junio
2002-08-29 3:15 ` Rusty Russell
2002-08-29 15:39 ` Thunder from the hill
2002-08-29 15:48 ` Dave Jones
2002-08-30 3:50 ` Rusty Russell
[not found] <20020829031008.T7920@devserv.devel.redhat.com.suse.lists.linux.kernel>
[not found] ` <Pine.LNX.4.44.0208290955280.2070-100000@home.transmeta.com.suse.lists.linux.kernel>
2002-08-29 17:23 ` Andi Kleen
2002-08-29 17:51 ` Alexander Viro
2002-08-29 17:53 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020828221716.2C1D12C0E8@lists.samba.org \
--to=rusty@rustcorp.com.au \
--cc=junkio@cox.net \
--cc=kaos@ocs.com.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®