From: "David S. Miller" <davem@redhat.com>
To: beezly@beezly.org.uk
Cc: hch@infradead.org, neilb@cse.unsw.edu.au, bcollins@debian.org,
linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org
Subject: Re: OOPS: ext3/sparc badness
Date: Fri, 30 Aug 2002 17:18:12 -0700 (PDT) [thread overview]
Message-ID: <20020830.171812.108191988.davem@redhat.com> (raw)
In-Reply-To: <20020521083805.GC18501@monkey.beezly.org.uk>
From: Andrew Beresford <beezly@beezly.org.uk>
Date: Tue, 21 May 2002 09:38:05 +0100
On Tue, May 21, 2002 at 01:18:58AM -0700, David S. Miller wrote:
> I don't think so... but please repost the link as I've deleted all of
> your emails.
The link is;
http://marc.theaimsgroup.com/?l=linux-raid&m=101981888804890&w=2
To recap, the compiler used to build sparc64 kernels miscompiles
drivers/md/raid1.c:raid1_read_balance()
The following appears to be a good workaround for this
bug, Neil could you put this into your tree and would you
mind if I sent this to Marcelo for 2.4.20-preX?
--- drivers/md/raid1.c.~1~ Fri Aug 30 17:03:02 2002
+++ drivers/md/raid1.c Fri Aug 30 17:17:46 2002
@@ -23,6 +23,7 @@
*/
#include <linux/module.h>
+#include <linux/config.h>
#include <linux/slab.h>
#include <linux/raid/raid1.h>
#include <asm/atomic.h>
@@ -522,6 +523,10 @@
if (conf->sect_count >= conf->mirrors[new_disk].sect_limit) {
conf->sect_count = 0;
+#if defined(CONFIG_SPARC64) && (__GNUC__ == 2) && (__GNUC_MINOR__ == 92)
+ /* Work around a compiler bug in egcs-2.92.11 19980921 */
+ new_disk = *(volatile int *)&new_disk;
+#endif
do {
if (new_disk<=0)
new_disk = conf->raid_disks;
prev parent reply other threads:[~2002-08-31 0:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-20 12:32 Beezly
2002-05-20 14:55 ` Beezly
2002-05-20 21:30 ` David S. Miller
2002-05-20 21:52 ` Christoph Hellwig
2002-05-20 22:06 ` David S. Miller
2002-05-21 8:30 ` Andrew Beresford
2002-05-21 8:18 ` David S. Miller
2002-05-21 8:38 ` Andrew Beresford
2002-05-21 8:34 ` David S. Miller
2002-05-21 9:08 ` Andrew Beresford
2002-08-31 0:18 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020830.171812.108191988.davem@redhat.com \
--to=davem@redhat.com \
--cc=bcollins@debian.org \
--cc=beezly@beezly.org.uk \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@cse.unsw.edu.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®