* Re: [PATCH][2.5] set pci dma mask for ohci-hcd
@ 2002-09-01 23:21 David Brownell
2002-09-02 0:14 ` David S. Miller
0 siblings, 1 reply; 3+ messages in thread
From: David Brownell @ 2002-09-01 23:21 UTC (permalink / raw)
To: Zwane Mwaikambo; +Cc: linux-kernel
Last I looked, that value was documented to be the
default. Setting the default is not necessary, and
if it were done it should be done once (hcd.c) not
get repeated for every driver.
- Dave
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][2.5] set pci dma mask for ohci-hcd
2002-09-01 23:21 [PATCH][2.5] set pci dma mask for ohci-hcd David Brownell
@ 2002-09-02 0:14 ` David S. Miller
0 siblings, 0 replies; 3+ messages in thread
From: David S. Miller @ 2002-09-02 0:14 UTC (permalink / raw)
To: david-b; +Cc: zwane, linux-kernel
From: David Brownell <david-b@pacbell.net>
Date: Sun, 01 Sep 2002 16:21:12 -0700
Last I looked, that value was documented to be the
default.
That is correct.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH][2.5] set pci dma mask for ohci-hcd
@ 2002-09-01 14:11 Zwane Mwaikambo
0 siblings, 0 replies; 3+ messages in thread
From: Zwane Mwaikambo @ 2002-09-01 14:11 UTC (permalink / raw)
To: Greg Kroah-Hartmann; +Cc: Linux Kernel
Index: linux-2.5.33/drivers/usb/host/ohci-pci.c
===================================================================
RCS file: /build/cvsroot/linux-2.5.33/drivers/usb/host/ohci-pci.c,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 ohci-pci.c
--- linux-2.5.33/drivers/usb/host/ohci-pci.c 31 Aug 2002 22:30:41 -0000 1.1.1.1
+++ linux-2.5.33/drivers/usb/host/ohci-pci.c 1 Sep 2002 12:41:23 -0000
@@ -36,6 +36,11 @@
int ret;
if (hcd->pdev) {
+ if (pci_set_dma_mask(hcd->pdev, 0xFFFFFFFF)) {
+ err("couldn't set PCI dma mask");
+ return -EIO;
+ }
+
ohci->hcca = pci_alloc_consistent (hcd->pdev,
sizeof *ohci->hcca, &ohci->hcca_dma);
if (!ohci->hcca)
--
function.linuxpower.ca
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2002-09-02 0:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-09-01 23:21 [PATCH][2.5] set pci dma mask for ohci-hcd David Brownell
2002-09-02 0:14 ` David S. Miller
-- strict thread matches above, loose matches on Subject: below --
2002-09-01 14:11 Zwane Mwaikambo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome