2.5.33 compile error in ipv6

2.5.33 compile error in ipv6

[Clemens Schwaighofer]

hi,

my typical test system: std rh 7.3 + gcc-3.2 from rawhide

I applied the aty FB patches, cause build would fail there too.

then this ...

make[3]: Entering directory `/usr/src/kernel/2.5.33/linux-2.5.33/net/ipv6'
  gcc -Wp,-MD,./.af_inet6.o.d -D__KERNEL__ 
-I/usr/src/kernel/2.5.33/linux-2.5.33/include -Wall -Wstrict-prototypes 
-Wno-trigraphs -O2 -fomit-frame-pointer -fno-strict-aliasing -fno-common 
-pipe -mpreferred-stack-boundary=2 -march=i686 -nostdinc -iwithprefix 
include    -DKBUILD_BASENAME=af_inet6   -c -o af_inet6.o af_inet6.c
af_inet6.c: In function `inet6_init':
af_inet6.c:666: called object is not a function
af_inet6.c:667: parse error before string constant
make[3]: *** [af_inet6.o] Error 1
make[3]: Leaving directory `/usr/src/kernel/2.5.33/linux-2.5.33/net/ipv6'
make[2]: *** [ipv6] Error 2
make[2]: Leaving directory `/usr/src/kernel/2.5.33/linux-2.5.33/net'
make[1]: *** [net] Error 2
make[1]: Leaving directory `/usr/src/kernel/2.5.33/linux-2.5.33'
make: *** [bzImage] Error 2

I saw no patch in ML yet for this ...

-- 
"Der Krieg ist ein Massaker von Leuten, die sich nicht kennen, zum
Nutzen von Leuten, die sich kennen, aber nicht massakrieren"
- Paul Valéry (1871-1945)
mfg, Clemens Schwaighofer                       PIXELWINGS Medien GMBH
Kandlgasse 15/5, A-1070 Wien                      T: [+43 1] 524 58 50
JETZT NEU! MIT FEWA GEWASCHEN       -->      http://www.pixelwings.com

Re: 2.5.33 compile error in ipv6

[David S. Miller]

   From: Clemens Schwaighofer <cs@pixelwings.com>
   Date: Mon, 2 Sep 2002 13:06:13 +0200 (CEST)
   
   I saw no patch in ML yet for this ...

Actually, there was, lines 666 and 667 of net/ipv6/af_inet6.c
should read:

                printk(KERN_CRIT "%s: Can't create protocol sock SLAB "
                       "caches!\n", __FUNCTION__);

Here is the patch against 2.5.33 that James Morris posted.

diff -Nru a/net/ipv6/af_inet6.c b/net/ipv6/af_inet6.c
--- a/net/ipv6/af_inet6.c       Mon Sep  2 16:28:13 2002
+++ b/net/ipv6/af_inet6.c       Mon Sep  2 16:28:13 2002
@@ -663,8 +663,8 @@
                                           sizeof(struct raw6_sock), 0,
                                            SLAB_HWCACHE_ALIGN, 0, 0);
         if (!tcp6_sk_cachep || !udp6_sk_cachep || !raw6_sk_cachep)
-                printk(KERN_CRIT __FUNCTION__
-                        ": Can't create protocol sock SLAB caches!\n");
+                printk(KERN_CRIT "%s: Can't create protocol sock SLAB "
+                      "caches!\n", __FUNCTION__);

        /* Register the socket-side information for inet6_create.  */
        for(r = &inetsw6[0]; r < &inetsw6[SOCK_MAX]; ++r)