Re: 2.4.19-ac4 build problem

Re: 2.4.19-ac4 build problem

[Peter]

Hi Greg -

Agree -- I couldn't find it either. This may be a makefile error:

linux-2.4.19-ac4 # grep usbdrv.o * -r
Makefile:DRIVERS-$(CONFIG_USB) += drivers/usb/usbdrv.o
drivers/usb/Makefile:O_TARGET   := usbdrv.o

The kernel compiled fine when I defined Input core support in the kernel
rather than as modules (cf. below). And USB is working great -- keyboard, 
cordless mouse, webcam, scanner, printer, the works.

Cheers,
Peter


Does not compile:

#
# Input core support
#
CONFIG_INPUT=m
CONFIG_INPUT_KEYBDEV=m
CONFIG_INPUT_MOUSEDEV=m
CONFIG_INPUT_MOUSEDEV_SCREEN_X=1024
CONFIG_INPUT_MOUSEDEV_SCREEN_Y=768
CONFIG_INPUT_JOYDEV=m
# CONFIG_INPUT_EVDEV is not set

Compiles:

#
# Input core support
#
CONFIG_INPUT=y
CONFIG_INPUT_KEYBDEV=y
CONFIG_INPUT_MOUSEDEV=y
CONFIG_INPUT_MOUSEDEV_SCREEN_X=1024
CONFIG_INPUT_MOUSEDEV_SCREEN_Y=768
CONFIG_INPUT_JOYDEV=y
CONFIG_INPUT_EVDEV=y

I don't know if the last two lines matter.

Re: 2.4.19-ac4 build problem

[Greg KH]

On Wed, Sep 04, 2002 at 01:19:33PM -0700, Peter wrote:
> 
> Hi Greg -
> 
> Agree -- I couldn't find it either. This may be a makefile error:
> 
> linux-2.4.19-ac4 # grep usbdrv.o * -r
> Makefile:DRIVERS-$(CONFIG_USB) += drivers/usb/usbdrv.o
> drivers/usb/Makefile:O_TARGET   := usbdrv.o

Ah, stupid me, you were building USB into the kernel, so this is the usb
.o file.  Sorry for the confusion.

> The kernel compiled fine when I defined Input core support in the kernel
> rather than as modules (cf. below). And USB is working great -- keyboard, 
> cordless mouse, webcam, scanner, printer, the works.

Hm, I think you will have to compile the input stuff into the core, if
you want your USB input drivers to link properly.  So there's really no
way around this.

thanks,

greg k-h

Re: 2.4.19-ac4 build problem

[Greg KH]

<offtopic, your site keeps refusing my direct email due to a procmail
configuration bug on your site>

On Thu, Sep 05, 2002 at 01:00:33AM -0700, Peter wrote:
> 
> In that case, let's add this to the help screens for the three device
> types (CONFIG_INPUT_KEYBDEV, CONFIG_INPUT_MOUSEDEV, CONFIG_INPUT_JOYDEV), 
> after the current text:
> 
> For the drivers to link correctly, you must make the same selection (Y or
> M) here as for the USB Human Interface Device (full HID) support.
> 
> Under CONFIG_USB_HID, likewise add after the current text:
> 
> For the drivers to link correctly, you must make the same selection (Y or
> M) here as for Input core support.

That sounds reasonable.

> That said, I suggest that Input core support menu be moved into the USB
> support menu, where these dependency relations can be automated and made 
> visible to the user. 

No, the Input core is separate from the USB code, it does not belong in
that menu.

> I apologize for not submitting a patch -- it's a skill I lack.

Take a look at Documentation/SubmittingPatches, it should help you learn
those skills :)

thanks,

greg k-h

Re: 2.4.19-ac4 build problem

[Peter]

>No, because it works just fine when you build the USB drivers as
>modules, and the Input core as modules, which is what the majority of
>people do.

In that case, let's add this to the help screens for the three device
types (CONFIG_INPUT_KEYBDEV, CONFIG_INPUT_MOUSEDEV, CONFIG_INPUT_JOYDEV), 
after the current text:

For the drivers to link correctly, you must make the same selection (Y or
M) here as for the USB Human Interface Device (full HID) support.

Under CONFIG_USB_HID, likewise add after the current text:

For the drivers to link correctly, you must make the same selection (Y or
M) here as for Input core support.

That said, I suggest that Input core support menu be moved into the USB
support menu, where these dependency relations can be automated and made 
visible to the user. 

I apologize for not submitting a patch -- it's a skill I lack.

Cheers,
Peter.

Re: 2.4.19-ac4 build problem

[Greg KH]

On Wed, Sep 04, 2002 at 08:59:55PM -0700, Peter wrote:
> 
> > Hm, I think you will have to compile the input stuff into the core, if
> > you want your USB input drivers to link properly.  So there's really no
> > way around this.
> 
> In that case, why don't we remove the choice to make modules in input core
> support? 

No, because it works just fine when you build the USB drivers as
modules, and the Input core as modules, which is what the majority of
people do.

> If there's some reason to keep it, let's save someone some grief and add a
> note to CONFIG_INPUT:
> 
> Note that in most cases, input support must be compiled into the core for
> your USB input drivers to link properly.

Again, not true.  It just has to match the same value for the USB input
drivers.  A patch with this kind of wording would be greatly
appreciated.

thanks,

greg k-h

Re: 2.4.19-ac4 build problem

[Peter]

> Hm, I think you will have to compile the input stuff into the core, if
> you want your USB input drivers to link properly.  So there's really no
> way around this.

In that case, why don't we remove the choice to make modules in input core
support? 

If there's some reason to keep it, let's save someone some grief and add a
note to CONFIG_INPUT:

Note that in most cases, input support must be compiled into the core for
your USB input drivers to link properly.

Alternatively, add this text to the help screens for the three device
types.

Cheers,
Peter

Re: 2.4.19-ac4 build problem

[Greg KH]

On Tue, Sep 03, 2002 at 10:50:59PM -0700, Peter wrote:
> 
> Is there a fix for this compilation problem? I've tried gcc 2.95.3, 3.0, 
> and 3.1 and get the same:
> 
> drivers/usb/usbdrv.o: In function `hidinput_hid_event':

What driver is this?  It isn't in the main 2.4.x tree.

thanks,

greg k-h

2.4.19-ac4 build problem

[Peter]

Is there a fix for this compilation problem? I've tried gcc 2.95.3, 3.0, 
and 3.1 and get the same:

drivers/usb/usbdrv.o: In function `hidinput_hid_event':
drivers/usb/usbdrv.o(.text+0x127f1): undefined reference to `input_event'
drivers/usb/usbdrv.o(.text+0x12889): undefined reference to `input_event'
drivers/usb/usbdrv.o(.text+0x128e1): undefined reference to `input_event'
drivers/usb/usbdrv.o(.text+0x12967): undefined reference to `input_event'
drivers/usb/usbdrv.o: In function `hidinput_connect':
drivers/usb/usbdrv.o(.text+0x12bc0): undefined reference to `input_register_device'
drivers/usb/usbdrv.o: In function `hidinput_hid_event':
drivers/usb/usbdrv.o(.text+0x12848): undefined reference to `input_event'
drivers/usb/usbdrv.o: In function `hidinput_disconnect':
drivers/usb/usbdrv.o(.text+0x12bdd): undefined reference to `input_unregister_device'
make: *** [vmlinux] Error 1

I'm trying to get USB keyboard and mouse support, so I'd like to keep the 
hidinput options.

Cheers,
Peter


#
# Input core support
#
CONFIG_INPUT=m
CONFIG_INPUT_KEYBDEV=m
CONFIG_INPUT_MOUSEDEV=m
CONFIG_INPUT_MOUSEDEV_SCREEN_X=1024
CONFIG_INPUT_MOUSEDEV_SCREEN_Y=768
CONFIG_INPUT_JOYDEV=m
# CONFIG_INPUT_EVDEV is not set

#
# USB support
#
CONFIG_USB=y
# CONFIG_USB_DEBUG is not set

#
# Miscellaneous USB options
#
CONFIG_USB_DEVICEFS=y
# CONFIG_USB_BANDWIDTH is not set
# CONFIG_USB_LONG_TIMEOUT is not set

#
# USB Host Controller Drivers
#
CONFIG_USB_EHCI_HCD=m
CONFIG_USB_UHCI=y
# CONFIG_USB_UHCI_ALT is not set
# CONFIG_USB_OHCI is not set


#
# USB Device Class drivers
#
# CONFIG_USB_AUDIO is not set
# CONFIG_USB_BLUETOOTH is not set
CONFIG_USB_STORAGE=m
# CONFIG_USB_STORAGE_DEBUG is not set
# CONFIG_USB_STORAGE_DATAFAB is not set
# CONFIG_USB_STORAGE_FREECOM is not set
CONFIG_USB_STORAGE_ISD200=y
# CONFIG_USB_STORAGE_DPCM is not set
# CONFIG_USB_STORAGE_HP8200e is not set
# CONFIG_USB_STORAGE_SDDR09 is not set
# CONFIG_USB_STORAGE_JUMPSHOT is not set
# CONFIG_USB_ACM is not set
CONFIG_USB_PRINTER=y

#
# USB Human Interface Devices (HID)
#
CONFIG_USB_HID=y
CONFIG_USB_HIDINPUT=y
# CONFIG_USB_HIDDEV is not set
# CONFIG_USB_WACOM is not set

#
# USB Imaging devices
#
# CONFIG_USB_DC2XX is not set
# CONFIG_USB_MDC800 is not set
CONFIG_USB_SCANNER=m
# CONFIG_USB_MICROTEK is not set
# CONFIG_USB_MICROTEK is not set
# CONFIG_USB_HPUSBSCSI is not set

No additional USB devices are set.