2.5.34 - EXPORT_SYMBOL(reparent_to_init) for module build

2.5.34 - EXPORT_SYMBOL(reparent_to_init) for module build

[Patrick Mansfield]

With 2.5.34, in order to build a module that calls daemonize(), I had to 
export reparent_to_init:

--- 1.45/kernel/ksyms.c	Mon Sep  9 03:35:51 2002
+++ edited/kernel/ksyms.c	Mon Sep  9 16:52:29 2002
@@ -521,6 +521,7 @@
 EXPORT_SYMBOL(securebits);
 EXPORT_SYMBOL(cap_bset);
 EXPORT_SYMBOL(daemonize);
+EXPORT_SYMBOL(reparent_to_init);
 EXPORT_SYMBOL(csum_partial); /* for networking and md */
 EXPORT_SYMBOL(seq_escape);
 EXPORT_SYMBOL(seq_printf);

-- Patrick Mansfield

Re: 2.5.34 - EXPORT_SYMBOL(reparent_to_init) for module build

[John Levon]

On Mon, Sep 09, 2002 at 05:21:11PM -0700, Patrick Mansfield wrote:

> With 2.5.34, in order to build a module that calls daemonize(), I had to 
> export reparent_to_init:

I suggest you check the source of daemonize() in 2.5.34 ;)

regards
john
-- 
"This *is* Usenet, after all, where virtually every conversation that goes on
is fairly ludicrous in the first place."
	- Godwin's Law FAQ

Re: 2.5.34 - EXPORT_SYMBOL(reparent_to_init) for module build

[Patrick Mansfield]

On Tue, Sep 10, 2002 at 01:24:18AM +0100, John Levon wrote:
> On Mon, Sep 09, 2002 at 05:21:11PM -0700, Patrick Mansfield wrote:
> 
> > With 2.5.34, in order to build a module that calls daemonize(), I had to 
> > export reparent_to_init:
> 
> I suggest you check the source of daemonize() in 2.5.34 ;)
> 
> regards
> john

OK, thanks, I thought I grepped the module source (qla v6b5 adapter, not
included in the kernel tree), but missed the call to reparent_to_init().
I was wondering why I'd need an export for a function only called from
within in its own file. I removed the reparent_to_init call and it worked
fine.

Perhaps reparent_to_init should now be static?

Thanks.

-- Patrick Mansfield

Re: 2.5.34 - EXPORT_SYMBOL(reparent_to_init) for module build

[John Levon]

On Mon, Sep 09, 2002 at 06:12:16PM -0700, Patrick Mansfield wrote:

> Perhaps reparent_to_init should now be static?

My grep certainly agrees with this. (Don't forget to remove the
prototype in sched.h too).

regards
john

-- 
"This *is* Usenet, after all, where virtually every conversation that goes on
is fairly ludicrous in the first place."
	- Godwin's Law FAQ

Re: 2.5.34 - EXPORT_SYMBOL(reparent_to_init) for module build

[Rusty Russell]

In message <20020909172111.A19949@eng2.beaverton.ibm.com> you write:
> With 2.5.34, in order to build a module that calls daemonize(), I had to 
> export reparent_to_init:

Why?

Rusty.
--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.