Re: [PATCH][RESEND] Cleanup (BIN|BCD)_TO_(BCD|BIN) usage/macros

[Tom Rini <trini@kernel.crashing.org>]

On Tue, Sep 17, 2002 at 02:39:59PM -0400, Jeff Garzik wrote:

> Tom Rini wrote:
> >Right now there's a bit of a mess with all of the BIN_TO_BCD/BCD_TO_BIN
> >macros in the kernel.  It's defined in a half dozen places, and worse
> >yet, not all places use them the same way.  Most users do something
> >like:
> >if ( ... )
> >   BIN_TO_BCD(x);
> >
> >But in a few places, it's used as:
> >if ( ... )
> >   y = BIN_TO_BCD(x);
> >
> >The following creates include/linux/bcd.h which has the 'normal'
> >BIN_TO_BCD macros, as well as CONVERT_{BIN,BCD}_TO_{BCD,BIN},
> >which are for the second case.
> 
> hmmm... removing all the private definitions certainly makes good sense, 
> but having both CONVERT_foo and foo seems a bit wonky...
> 
> IMO it would be better to have BIN_TO_BCD which returns a value, and 
> __BIN_TO_BCD which has side effects but returns no value...

The other thing, is that in general people seem to expect BIN_TO_BCD(X) to
not return a value, and just convert X.  Would it be better to replace
CONVERT_x to __x then ?

-- 
Tom Rini (TR1265)
http://gate.crashing.org/~trini/