From: Jeff Garzik <jgarzik@mandrakesoft.com>
To: Tom Rini <trini@kernel.crashing.org>
Cc: Linus Torvalds <torvalds@transmeta.com>,
Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][RESEND] Cleanup (BIN|BCD)_TO_(BCD|BIN) usage/macros
Date: Fri, 20 Sep 2002 10:56:08 -0400 [thread overview]
Message-ID: <3D8B3708.2060205@mandrakesoft.com> (raw)
In-Reply-To: <20020920143931.GH726@opus.bloom.county>
Tom Rini wrote:
> The other thing, is that in general people seem to expect BIN_TO_BCD(X) to
> not return a value, and just convert X. Would it be better to replace
> CONVERT_x to __x then ?
My gut feeling is that the users in the majority -- the ones that don't
return a value -- are still abnormal. Side effects on arguments are the
rare case in C, even if it is the common case here.
But to answer your question, I think s/CONVERT_x/__x/ is better than
nothing...
Jeff
prev parent reply other threads:[~2002-09-20 14:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-17 18:29 Tom Rini
2002-09-17 18:39 ` Jeff Garzik
2002-09-17 18:49 ` Tom Rini
2002-09-20 14:39 ` Tom Rini
2002-09-20 14:56 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D8B3708.2060205@mandrakesoft.com \
--to=jgarzik@mandrakesoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=trini@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®