From: Alan Cox <alan@redhat.com>
To: preining@logic.at (Norbert Preining)
Cc: linux-kernel@vger.kernel.org, alan@redhat.com (Alan Cox)
Subject: Re: ac-patches kill maestro3 sound driver on 2.4.20-pre7 and pre8
Date: Sun, 29 Sep 2002 17:43:26 -0400 (EDT) [thread overview]
Message-ID: <200209292143.g8TLhQx11223@devserv.devel.redhat.com> (raw)
In-Reply-To: <20020929213524.GA4407@gamma.logic.tuwien.ac.at> from "Norbert Preining" at Sep 29, 2002 11:35:24 PM
> I tried the 2.4.20-pre7-ac3 patch and the 2.4.20-pre8-ac1 patch and in
> both cases the sound output is not working with a maestro3 sound chip
> (dell notebook inspiron i8000k). It is working with vanilla 2.4.20-pre7.
Humm try:
--- linux.20pre8-ac2/drivers/sound/maestro3.c~ 2002-09-29 22:47:50.000000000 +0100
+++ linux.20pre8-ac2/drivers/sound/maestro3.c 2002-09-29 22:47:50.000000000 +0100
@@ -2473,7 +2473,7 @@
if(!external_amp)
return;
- if (0 <= gpio_pin <= 15) {
+ if (gpio_pin >= 0 && gpio_pin <= 15) {
polarity_port = 0x1000 + (0x100 * gpio_pin);
} else {
switch (card->card_type) {
prev parent reply other threads:[~2002-09-29 21:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-29 21:35 Norbert Preining
2002-09-29 21:43 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200209292143.g8TLhQx11223@devserv.devel.redhat.com \
--to=alan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=preining@logic.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®