* ac-patches kill maestro3 sound driver on 2.4.20-pre7 and pre8
@ 2002-09-29 21:35 Norbert Preining
2002-09-29 21:43 ` Alan Cox
0 siblings, 1 reply; 2+ messages in thread
From: Norbert Preining @ 2002-09-29 21:35 UTC (permalink / raw)
To: linux-kernel; +Cc: Alan Cox
Hi!
I tried the 2.4.20-pre7-ac3 patch and the 2.4.20-pre8-ac1 patch and in
both cases the sound output is not working with a maestro3 sound chip
(dell notebook inspiron i8000k). It is working with vanilla 2.4.20-pre7.
Best wishes
Norbert
-------------------------------------------------------------------------------
Norbert Preining <preining AT logic DOT at> Technische Universität Wien
gpg DSA: 0x09C5B094 fp: 14DF 2E6C 0307 BE6D AD76 A9C0 D2BF 4AA3 09C5 B094
-------------------------------------------------------------------------------
YEPPOON (n.)
One of the hat-hanging corks which Australians wear for making Qantas
commercials.
--- Douglas Adams, The Meaning of Liff
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: ac-patches kill maestro3 sound driver on 2.4.20-pre7 and pre8
2002-09-29 21:35 ac-patches kill maestro3 sound driver on 2.4.20-pre7 and pre8 Norbert Preining
@ 2002-09-29 21:43 ` Alan Cox
0 siblings, 0 replies; 2+ messages in thread
From: Alan Cox @ 2002-09-29 21:43 UTC (permalink / raw)
To: Norbert Preining; +Cc: linux-kernel, Alan Cox
> I tried the 2.4.20-pre7-ac3 patch and the 2.4.20-pre8-ac1 patch and in
> both cases the sound output is not working with a maestro3 sound chip
> (dell notebook inspiron i8000k). It is working with vanilla 2.4.20-pre7.
Humm try:
--- linux.20pre8-ac2/drivers/sound/maestro3.c~ 2002-09-29 22:47:50.000000000 +0100
+++ linux.20pre8-ac2/drivers/sound/maestro3.c 2002-09-29 22:47:50.000000000 +0100
@@ -2473,7 +2473,7 @@
if(!external_amp)
return;
- if (0 <= gpio_pin <= 15) {
+ if (gpio_pin >= 0 && gpio_pin <= 15) {
polarity_port = 0x1000 + (0x100 * gpio_pin);
} else {
switch (card->card_type) {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2002-09-29 21:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-09-29 21:35 ac-patches kill maestro3 sound driver on 2.4.20-pre7 and pre8 Norbert Preining
2002-09-29 21:43 ` Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®