[PATCH] sparc64 makefile dep fix for uart_console_init

[PATCH] sparc64 makefile dep fix for uart_console_init

[Andres Salomon]

[-- Attachment #1: Type: text/plain, Size: 551 bytes --]

drivers/serial/Config.in defines the following:
if [ "$CONFIG_SPARC32" = "y" -o "$CONFIG_SPARC64" = "y" ]; then
	define_bool CONFIG_SERIAL_SUNCORE y
	define_bool CONFIG_SERIAL_CORE_CONSOLE y

There are no deps for CONFIG_SERIAL_CORE_CONSOLE in
drivers/serial/Makefile, so core.o isn't built on sparc32/64, and
linking gives an undefined reference to uart_console_init() error.  Not
sure if this is the desired way to deal w/ such deps, but it gets the
job done.

-- 
It's not denial.  I'm just selective about the reality I accept.
	-- Bill Watterson

[-- Attachment #2: serialmake.diff --]
[-- Type: text/plain, Size: 454 bytes --]

--- drivers/serial/Makefile.orig	2002-10-12 04:01:19.000000000 -0400
+++ drivers/serial/Makefile	2002-10-12 04:02:29.000000000 -0400
@@ -10,6 +10,7 @@
 serial-8250-$(CONFIG_PCI) += 8250_pci.o
 serial-8250-$(CONFIG_ISAPNP) += 8250_pnp.o
 obj-$(CONFIG_SERIAL_CORE) += core.o
+obj-$(CONFIG_SERIAL_CORE_CONSOLE) += core.o
 obj-$(CONFIG_SERIAL_21285) += 21285.o
 obj-$(CONFIG_SERIAL_8250) += 8250.o $(serial-8250-y)
 obj-$(CONFIG_SERIAL_8250_CS) += 8250_cs.o

Re: [PATCH] sparc64 makefile dep fix for uart_console_init

[David S. Miller]

   From: Andres Salomon <dilinger@mp3revolution.net>
   Date: Sat, 12 Oct 2002 04:24:05 -0400

   drivers/serial/Config.in defines the following:
   if [ "$CONFIG_SPARC32" = "y" -o "$CONFIG_SPARC64" = "y" ]; then
   	define_bool CONFIG_SERIAL_SUNCORE y
   	define_bool CONFIG_SERIAL_CORE_CONSOLE y
   
   There are no deps for CONFIG_SERIAL_CORE_CONSOLE in
   drivers/serial/Makefile

Yeah that's weird.  Just enable one of the sun serial
drivers for now and it will fix itself.

Probably a fix could be to add CONFIG_SERIAL_SUNCORE to the
checks that set CONFIG_SERIAL_CORE, I think that's how I'll
fix this.

Re: [PATCH] sparc64 makefile dep fix for uart_console_init

[Russell King]

On Sat, Oct 12, 2002 at 01:35:07AM -0700, David S. Miller wrote:
> Probably a fix could be to add CONFIG_SERIAL_SUNCORE to the
> checks that set CONFIG_SERIAL_CORE, I think that's how I'll
> fix this.

Agreed.  Do you want me to make the change?

-- 
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html

Re: [PATCH] sparc64 makefile dep fix for uart_console_init

[David S. Miller]

   From: Russell King <rmk@arm.linux.org.uk>
   Date: Sat, 12 Oct 2002 09:53:48 +0100

   On Sat, Oct 12, 2002 at 01:35:07AM -0700, David S. Miller wrote:
   > Probably a fix could be to add CONFIG_SERIAL_SUNCORE to the
   > checks that set CONFIG_SERIAL_CORE, I think that's how I'll
   > fix this.
   
   Agreed.  Do you want me to make the change?

Yes, please do.