2.5.43: "fix old protocol handler pppoe_rcv+0x0/0x124 [pppoe]"

2.5.43: "fix old protocol handler pppoe_rcv+0x0/0x124 [pppoe]"

[Adam J. Richter]

	In linux-2.5.42 and .43, I get this recurring error message:

fix old protocol handler pppoe_rcv+0x0/0x124 [pppoe]

	which is apparently from deliver_to_old_ones() in net/core/dev.c:

#if CONFIG_SMP
        /* Old protocols did not depened on BHs different of NET_BH and
           TIMER_BH - they need to be fixed for the new assumptions.
         */
        print_symbol("fix old protocol handler %s!\n", (unsigned long)pt->func)\
;
#endif

	I'm puzzling out exactly change this message is requesting,
and I thought it might be a better use of everyone's time if I first
ask if there is a porting guide or other document about converting an
"old" style protocol handler to a "new" one.

Adam J. Richter     __     ______________   575 Oroville Road
adam@yggdrasil.com     \ /                  Milpitas, California 95035
+1 408 309-6081         | g g d r a s i l   United States of America
                         "Free Software For The Rest Of Us."

Re: 2.5.43: "fix old protocol handler pppoe_rcv+0x0/0x124 [pppoe]"

[David S. Miller]

   From: "Adam J. Richter" <adam@yggdrasil.com>
   Date: Thu, 17 Oct 2002 13:10:56 -0700
   
   	I'm puzzling out exactly change this message is requesting,

Packet receive must be aware of shared skb's (it must make
a copy if it wants to modify packet contents) and it must
be fully SMP threaded.

Then ptype->data is changed to some non-NULL value to indicate that it
is a "new" protocol.