* Re: [patch] setup_arg_pages. ARCH_STACK_GROWSUP ??
@ 2002-10-20 1:38 Matthew Wilcox
0 siblings, 0 replies; 2+ messages in thread
From: Matthew Wilcox @ 2002-10-20 1:38 UTC (permalink / raw)
To: Marcus Alanen; +Cc: linux-kernel
> As far as I can see, setup_arg_pages code is hosed for the
> ARCH_STACK_GROWSUP case, completely wrong types... Does any arch even
> use this?
Yes, but kunmap is a NOP on that architecture, so nobody noticed. Patch
looks good though.
--
Revolutions do not require corporate support.
^ permalink raw reply [flat|nested] 2+ messages in thread
* [patch] setup_arg_pages. ARCH_STACK_GROWSUP ??
@ 2002-10-19 22:17 Marcus Alanen
0 siblings, 0 replies; 2+ messages in thread
From: Marcus Alanen @ 2002-10-19 22:17 UTC (permalink / raw)
To: linux-kernel; +Cc: trivial
As far as I can see, setup_arg_pages code is hosed for the
ARCH_STACK_GROWSUP case, completely wrong types... Does any arch even
use this?
Marcus
diff -Naurd --exclude-from=/home/maalanen/linux/base/diff_exclude linus-2.5.44/fs/exec.c msa-2.5.44/fs/exec.c
--- linus-2.5.44/fs/exec.c Wed Oct 16 16:31:15 2002
+++ msa-2.5.44/fs/exec.c Sat Oct 19 22:03:11 2002
@@ -354,11 +354,11 @@
memmove(to, to + offset, PAGE_SIZE - offset);
from = kmap(bprm->page[j]);
memcpy(to + PAGE_SIZE - offset, from, offset);
- kunmap(bprm[j - 1]);
+ kunmap(bprm->page[j - 1]);
to = from;
}
memmove(to, to + offset, PAGE_SIZE - offset);
- kunmap(bprm[j - 1]);
+ kunmap(bprm->page[j - 1]);
/* Adjust bprm->p to point to the end of the strings. */
bprm->p = PAGE_SIZE * i - offset;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2002-10-20 1:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-10-20 1:38 [patch] setup_arg_pages. ARCH_STACK_GROWSUP ?? Matthew Wilcox
-- strict thread matches above, loose matches on Subject: below --
2002-10-19 22:17 Marcus Alanen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome