* sound/core/wrappers.c __GENKSYMS__ usage
@ 2002-10-21 19:11 Sam Ravnborg
2002-10-22 10:43 ` Jaroslav Kysela
0 siblings, 1 reply; 2+ messages in thread
From: Sam Ravnborg @ 2002-10-21 19:11 UTC (permalink / raw)
To: Jaroslav Kysela; +Cc: linux-kernel
Hi Jaroslav
The usage of __GENKSYMS__ in sound/core/wrappers.c looks wrong.
>From the file:
#include <linux/version.h>
#include <linux/config.h>
#ifdef ALSA_BUILD
#if defined(CONFIG_MODVERSIONS) && !defined(__GENKSYMS__) && !defined(__DEPEND__)
#define MODVERSIONS
#include <linux/modversions.h>
#include "sndversions.h"
#endif
#endif
So __GENKSYMS__ etc is used to protect against inclusion of modversions.h
and sndversion.h.
The latter is not present in my tree (2.5.44).
__DEPEND__ is no longer used.
I do not see the purpose of this - please explain.
Sam
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: sound/core/wrappers.c __GENKSYMS__ usage
2002-10-21 19:11 sound/core/wrappers.c __GENKSYMS__ usage Sam Ravnborg
@ 2002-10-22 10:43 ` Jaroslav Kysela
0 siblings, 0 replies; 2+ messages in thread
From: Jaroslav Kysela @ 2002-10-22 10:43 UTC (permalink / raw)
To: Sam Ravnborg; +Cc: linux-kernel
On Mon, 21 Oct 2002, Sam Ravnborg wrote:
> Hi Jaroslav
>
> The usage of __GENKSYMS__ in sound/core/wrappers.c looks wrong.
>
> >From the file:
> #include <linux/version.h>
> #include <linux/config.h>
> #ifdef ALSA_BUILD
> #if defined(CONFIG_MODVERSIONS) && !defined(__GENKSYMS__) && !defined(__DEPEND__)
> #define MODVERSIONS
> #include <linux/modversions.h>
> #include "sndversions.h"
> #endif
> #endif
>
> So __GENKSYMS__ etc is used to protect against inclusion of modversions.h
> and sndversion.h.
> The latter is not present in my tree (2.5.44).
> __DEPEND__ is no longer used.
>
> I do not see the purpose of this - please explain.
It's for compatibility with older kernels. We use same sources for 2.2 and
2.4 kernels. Also notice that "problematic" #if is after ALSA_BUILD and
it's not defined for Linux kernel (we use this definition internally for
our build system).
Anyway, I'll move this code outside the kernel tree.
Jaroslav
-----
Jaroslav Kysela <perex@suse.cz>
Linux Kernel Sound Maintainer
ALSA Project http://www.alsa-project.org
SuSE Linux http://www.suse.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2002-10-22 10:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-10-21 19:11 sound/core/wrappers.c __GENKSYMS__ usage Sam Ravnborg
2002-10-22 10:43 ` Jaroslav Kysela
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®