* RE: [PATCH][RFC] add support for PC-9800 architecture (11/26) inp ut
@ 2002-10-23 1:42 Osamu Tomita
2002-10-23 9:17 ` Vojtech Pavlik
0 siblings, 1 reply; 2+ messages in thread
From: Osamu Tomita @ 2002-10-23 1:42 UTC (permalink / raw)
To: 'Vojtech Pavlik '; +Cc: 'LKML '
Thanks for many suggestion.
-----Original Message-----
From: Vojtech Pavlik
To: Osamu Tomita
Cc: LKML; Linus Torvalds
Sent: 2002/10/22 19:29
Subject: Re: [PATCH][RFC] add support for PC-9800 architecture (11/26) input
> Before I'll think of merging this, it has to be seriously cleaned up.
> Comments below.
I see. I work away at cleanup.
> (Summary: use your own SERIO_TYPE for the PC-98 keyboard, remove dead
> code and definitions, fix naming, make as little #ifdefs as possible,
> and maybe you can put the PC-98 keyboard code into xtkbd.c (in which
> case you may get away with SERIO_XT).
Since xtkbd has not write keyboard function, I modified atkbd.
I'll rewrite driver, keycode translations and (un)initialize using xtkbd's
way. Also rename identifier.
I don't touch input.h in next patch.
Regards
Osamu Tomita
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH][RFC] add support for PC-9800 architecture (11/26) inp ut
2002-10-23 1:42 [PATCH][RFC] add support for PC-9800 architecture (11/26) inp ut Osamu Tomita
@ 2002-10-23 9:17 ` Vojtech Pavlik
0 siblings, 0 replies; 2+ messages in thread
From: Vojtech Pavlik @ 2002-10-23 9:17 UTC (permalink / raw)
To: Osamu Tomita; +Cc: 'Vojtech Pavlik ', 'LKML '
On Wed, Oct 23, 2002 at 10:42:19AM +0900, Osamu Tomita wrote:
> Thanks for many suggestion.
>
> -----Original Message-----
> From: Vojtech Pavlik
> To: Osamu Tomita
> Cc: LKML; Linus Torvalds
> Sent: 2002/10/22 19:29
> Subject: Re: [PATCH][RFC] add support for PC-9800 architecture (11/26) input
>
> > Before I'll think of merging this, it has to be seriously cleaned up.
> > Comments below.
> I see. I work away at cleanup.
>
> > (Summary: use your own SERIO_TYPE for the PC-98 keyboard, remove dead
> > code and definitions, fix naming, make as little #ifdefs as possible,
> > and maybe you can put the PC-98 keyboard code into xtkbd.c (in which
> > case you may get away with SERIO_XT).
> Since xtkbd has not write keyboard function, I modified atkbd.
> I'll rewrite driver, keycode translations and (un)initialize using xtkbd's
> way. Also rename identifier.
> I don't touch input.h in next patch.
Great, thanks!
Yes, it's true that the xtkbd.c code has no way to set the LEDs on the
keyboard nor any functions that'd support sending bytes to the keyboard.
Anyway, the PC-9800 seems to have diverged from IBM machines at about
the time of the XT, and thus the keyboard controller in it (i8251) and
the keyboard itself speak much like they'd do on an IBM XT, with some
extensions like adding commands to set the LEDs, of course.
--
Vojtech Pavlik
SuSE Labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2002-10-23 9:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-10-23 1:42 [PATCH][RFC] add support for PC-9800 architecture (11/26) inp ut Osamu Tomita
2002-10-23 9:17 ` Vojtech Pavlik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®