mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH][2.5-AC] cistpl.c pcibios_read_config_dword
@ 2002-11-03 16:43 Zwane Mwaikambo
  2002-11-03 17:59 ` Russell King
  0 siblings, 1 reply; 3+ messages in thread
From: Zwane Mwaikambo @ 2002-11-03 16:43 UTC (permalink / raw)
  To: Alan Cox; +Cc: Linux Kernel

Sorry untested :/

Index: linux-2.5.44-ac5/drivers/pcmcia/cistpl.c
===================================================================
RCS file: /build/cvsroot/linux-2.5.44-ac5/drivers/pcmcia/cistpl.c,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 cistpl.c
--- linux-2.5.44-ac5/drivers/pcmcia/cistpl.c	3 Nov 2002 07:19:08 -0000	1.1.1.1
+++ linux-2.5.44-ac5/drivers/pcmcia/cistpl.c	3 Nov 2002 16:32:36 -0000
@@ -429,7 +429,7 @@
 #ifdef CONFIG_CARDBUS
     if (s->state & SOCKET_CARDBUS) {
 	u_int ptr;
-	pcibios_read_config_dword(s->cap.cb_dev->subordinate->number, 0, 0x28, &ptr);
+	pci_read_config_dword(s->cap.cb_dev, PCI_CARDBUS_CIS, &ptr);
 	tuple->CISOffset = ptr & ~7;
 	SPACE(tuple->Flags) = (ptr & 7);
     } else

-- 
function.linuxpower.ca



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH][2.5-AC] cistpl.c pcibios_read_config_dword
  2002-11-03 16:43 [PATCH][2.5-AC] cistpl.c pcibios_read_config_dword Zwane Mwaikambo
@ 2002-11-03 17:59 ` Russell King
  2002-11-03 18:14   ` Zwane Mwaikambo
  0 siblings, 1 reply; 3+ messages in thread
From: Russell King @ 2002-11-03 17:59 UTC (permalink / raw)
  To: Zwane Mwaikambo; +Cc: Alan Cox, Linux Kernel

On Sun, Nov 03, 2002 at 11:43:24AM -0500, Zwane Mwaikambo wrote:
> Sorry untested :/
> 
> Index: linux-2.5.44-ac5/drivers/pcmcia/cistpl.c
> ===================================================================
> RCS file: /build/cvsroot/linux-2.5.44-ac5/drivers/pcmcia/cistpl.c,v
> retrieving revision 1.1.1.1
> diff -u -r1.1.1.1 cistpl.c
> --- linux-2.5.44-ac5/drivers/pcmcia/cistpl.c	3 Nov 2002 07:19:08 -0000	1.1.1.1
> +++ linux-2.5.44-ac5/drivers/pcmcia/cistpl.c	3 Nov 2002 16:32:36 -0000
> @@ -429,7 +429,7 @@
>  #ifdef CONFIG_CARDBUS
>      if (s->state & SOCKET_CARDBUS) {
>  	u_int ptr;
> -	pcibios_read_config_dword(s->cap.cb_dev->subordinate->number, 0, 0x28, &ptr);
> +	pci_read_config_dword(s->cap.cb_dev, PCI_CARDBUS_CIS, &ptr);
>  	tuple->CISOffset = ptr & ~7;
>  	SPACE(tuple->Flags) = (ptr & 7);
>      } else

There is a patch that fixes this floating around.  The above isn't correct,
because we don't want to read s->cap.cb_dev (which is the bridge), but we
want to read the cardbus device that was just plugged in.

-- 
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH][2.5-AC] cistpl.c pcibios_read_config_dword
  2002-11-03 17:59 ` Russell King
@ 2002-11-03 18:14   ` Zwane Mwaikambo
  0 siblings, 0 replies; 3+ messages in thread
From: Zwane Mwaikambo @ 2002-11-03 18:14 UTC (permalink / raw)
  To: Russell King; +Cc: Alan Cox, Linux Kernel

On Sun, 3 Nov 2002, Russell King wrote:

> There is a patch that fixes this floating around.  The above isn't correct,
> because we don't want to read s->cap.cb_dev (which is the bridge), but we
> want to read the cardbus device that was just plugged in.

Thanks for the correction, i'll look around for the proper fix.

Cheers,	
	Zwane
-- 
function.linuxpower.ca


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2002-11-03 18:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-11-03 16:43 [PATCH][2.5-AC] cistpl.c pcibios_read_config_dword Zwane Mwaikambo
2002-11-03 17:59 ` Russell King
2002-11-03 18:14   ` Zwane Mwaikambo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®