From: Andreas Dilger <adilger@clusterfs.com>
To: Nikita Danilov <Nikita@Namesys.COM>
Cc: Tomas Szepe <szepe@pinerecords.com>,
Alexander Zarochentcev <zam@Namesys.COM>,
Hans Reiser <reiser@Namesys.COM>,
lkml <linux-kernel@vger.kernel.org>,
Oleg Drokin <green@Namesys.COM>, umka <umka@Namesys.COM>
Subject: Re: [BK][PATCH] Reiser4, will double Linux FS performance, pleaseapply
Date: Mon, 4 Nov 2002 12:56:29 -0700 [thread overview]
Message-ID: <20021104125629.A13158@munet-d.enel.ucalgary.ca> (raw)
In-Reply-To: <15814.21309.758207.21416@laputa.namesys.com>; from Nikita@Namesys.COM on Mon, Nov 04, 2002 at 02:00:13PM +0300
On Nov 04, 2002 14:00 +0300, Nikita Danilov wrote:
> > Jup, this fixes the leak, but free space still isn't reported accurately
> > until after sync gets called, which I believe is a bug too.
>
> In reiser4 allocation of disk space is delayed to transaction commit. It
> is not possible to estimate precisely amount of disk space that will be
> allocated during commit, and hence statfs(2) results are not updated
> until one does sync(2) (forcing commit) or transaction is committed due
> to age (10 minutes by default).
I find this more than a bit frightening, and it could obviously be a
huge source of reiser4's dramatic performance improvements - nothing is
being written to disk until long after a benchmark is complete (provided
you have enough RAM) if it isn't explicitly syncing before completing
the test (benchmarks like dbench and iozone don't necessarily sync).
Even more importantly, people losing 10 minutes of work is pretty
unacceptable, IMHO. The default flush interval is 30 seconds for a
reason, and in realistic scenarios files don't grow over a 10 minute
period, and even if they do you would want to start flushing that to
disk long before you have a few GB of outstanding changes. Also, this
would be a real source of problems (as I previously read was hinted at
in another reiser4 email) with filesystem full conditions.
At the very least, you need to reserve blocks in the filesystem for writes
that are under delayed allocation. Overestimating space requirements
(i.e. reserve a full block for each file, regardless of whether it will be
packed in the future or not) is far preferrable to underestimating and
running out of space after a write which already "completed" suddenly
finding itself out of space. If you get close to filling the filesystem,
then you can always flush the transaction to disk to "solidify your
estimates" before returning a needless ENOSPC. This will also make your
"statfs" space reporting fairly consistent, because you will return the
"reserved" stats even if they are only slightly off.
Cheers, Andreas
--
Andreas Dilger \ "If a man ate a pound of pasta and a pound of antipasto,
\ would they cancel out, leaving him still hungry?"
http://www-mddsp.enel.ucalgary.ca/People/adilger/ -- Dogbert
next prev parent reply other threads:[~2002-11-04 19:50 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-31 21:23 [BK][PATCH] Reiser4, will double Linux FS performance, please apply Hans Reiser
2002-10-31 22:34 ` Dieter Nützel
2002-10-31 22:47 ` Hans Reiser
2002-11-01 1:17 ` [BK][PATCH] Reiser4, will double Linux FS performance, pleaseapply Andrew Morton
2002-11-01 1:27 ` Andrew Morton
2002-11-01 1:27 ` Hans Reiser
2002-11-01 1:33 ` Andrew Morton
2002-11-01 1:44 ` Dieter Nützel
2002-11-01 1:55 ` Hans Reiser
2002-11-01 10:23 ` Tomas Szepe
2002-11-01 17:19 ` Alexander Zarochentcev
2002-11-02 13:24 ` Tomas Szepe
2002-11-04 11:00 ` Nikita Danilov
2002-11-04 19:56 ` Andreas Dilger [this message]
2002-11-05 7:30 ` reiser
2002-11-05 8:28 ` Alexander Zarochentcev
2002-11-05 8:44 ` reiser
2002-11-05 8:49 ` Alexander Zarochentcev
2002-11-05 21:08 ` reiser
2002-11-05 9:29 ` Andreas Dilger
2002-11-05 21:39 ` reiser
2002-11-05 9:59 ` Tomas Szepe
2002-11-05 10:08 ` Alexander Zarochentcev
2002-11-05 10:23 ` Tomas Szepe
2002-11-05 10:46 ` Nikita Danilov
2002-11-02 13:38 ` Tomas Szepe
2002-11-04 12:02 ` Nikita Danilov
2002-11-04 17:10 ` Tomas Szepe
2002-11-04 17:53 ` Nikita Danilov
2002-11-04 18:10 ` Tomas Szepe
2002-11-01 4:36 ` Linus Torvalds
2002-11-01 10:59 ` Nikita Danilov
[not found] <877555917@toto.iv>
2002-11-05 23:09 ` Peter Chubb
2002-11-06 1:33 ` reiser
2002-11-06 14:25 ` Daniel Egger
2002-11-07 17:19 ` Pavel Machek
2002-11-07 16:58 ` Bill Davidsen
2002-11-06 18:37 Tom Reinhart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021104125629.A13158@munet-d.enel.ucalgary.ca \
--to=adilger@clusterfs.com \
--cc=Nikita@Namesys.COM \
--cc=green@Namesys.COM \
--cc=linux-kernel@vger.kernel.org \
--cc=reiser@Namesys.COM \
--cc=szepe@pinerecords.com \
--cc=umka@Namesys.COM \
--cc=zam@Namesys.COM \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®