mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Matt Reppert <arashi@arashi.yi.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: linux-kernel@vger.kernel.org, rusty@rustcorp.com.au
Subject: Re: [PATCH] mii module broken under new scheme
Date: Tue, 19 Nov 2002 12:15:21 -0600	[thread overview]
Message-ID: <20021119121521.3789388a.arashi@arashi.yi.org> (raw)
In-Reply-To: <3DDA7A30.4010403@pobox.com>

On Tue, 19 Nov 2002 12:51:44 -0500
Jeff Garzik <jgarzik@pobox.com> wrote:

> Matt Reppert wrote:
> 
> > drivers/net/mii.c doesn't export module init/cleanup functions. That 
> > means it
> > can't be loaded under the new module scheme. This patch adds do-nothing
> > functions for it, which allows it to load. (8139too depends on mii, so
> > without this I don't have network.)
> 
> ahhh!   I was wondering what was up, but since I was busy with other 
> things I just compiled it into the kernel and continued on my way.
> 
> That's a bug in the new module loader.

Not so sure I agree ... recompiled the kernel with debugging output in
module.c and when I try to insert mii.o without above patch it complains
"Module has no name!" and returns -ENOEXEC from the syscall. I think
naming mii.o would be a good idea. This may not be the best way to do
it, but it works. (Granted, I'm not terribly familiar with all the
modules code changes yet, but ... ) Having anonymous output in lsmod
would be somewhat confusing :) ("Well, whatever it is, 8139too needs
it, don't touch it!")

Just noticed above patch is -p0. Whoops.

Matt

  reply	other threads:[~2002-11-19 18:07 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-19 17:50 Matt Reppert
2002-11-19 17:51 ` Jeff Garzik
2002-11-19 18:15   ` Matt Reppert [this message]
2002-11-19 18:37     ` Jeff Garzik
2002-11-21 21:34       ` Bill Davidsen
2002-11-19 21:38   ` Rusty Russell
2002-11-19 19:29 ` Alan Cox
2002-12-02  4:51 ` Rusty Russell
2002-11-19 18:14 Petr Vandrovec
2002-11-19 18:42 ` Jeff Garzik
2002-11-19 19:46 ` David Woodhouse
2002-11-19 18:21 Petr Vandrovec
2002-11-19 18:44 ` Jeff Garzik
2002-11-19 22:07   ` Rusty Russell
2002-11-19 21:49 ` Rusty Russell
2002-11-19 22:23 Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021119121521.3789388a.arashi@arashi.yi.org \
    --to=arashi@arashi.yi.org \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®