From: Rusty Russell <rusty@rustcorp.com.au>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: linux-kernel@vger.kernel.org, rusty@rustcorp.com.au
Subject: Re: [PATCH] mii module broken under new scheme
Date: Wed, 20 Nov 2002 08:38:52 +1100 [thread overview]
Message-ID: <20021120072654.1B6192C07A@lists.samba.org> (raw)
In-Reply-To: Your message of "Tue, 19 Nov 2002 12:51:44 CDT." <3DDA7A30.4010403@pobox.com>
In message <3DDA7A30.4010403@pobox.com> you write:
> Matt Reppert wrote:
>
> > drivers/net/mii.c doesn't export module init/cleanup functions. That
> > means it
> > can't be loaded under the new module scheme. This patch adds do-nothing
> > functions for it, which allows it to load. (8139too depends on mii, so
> > without this I don't have network.)
>
> ahhh! I was wondering what was up, but since I was busy with other
> things I just compiled it into the kernel and continued on my way.
>
> That's a bug in the new module loader.
Yes. But the workaround of calling the module "unknown" isn't nice
either: just put "no_module_init;" in and be done with it (it's also a
big hint that the module doesn't do anything itself).
Richard Henderson, Kai and myself are discussing a post-link stage for
modules, which will allow us to add the .modname section at that time,
but 99% of the cases are already fixed.
Sorry for any trouble,
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
next prev parent reply other threads:[~2002-11-20 7:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-11-19 17:50 Matt Reppert
2002-11-19 17:51 ` Jeff Garzik
2002-11-19 18:15 ` Matt Reppert
2002-11-19 18:37 ` Jeff Garzik
2002-11-21 21:34 ` Bill Davidsen
2002-11-19 21:38 ` Rusty Russell [this message]
2002-11-19 19:29 ` Alan Cox
2002-12-02 4:51 ` Rusty Russell
2002-11-19 18:14 Petr Vandrovec
2002-11-19 18:42 ` Jeff Garzik
2002-11-19 19:46 ` David Woodhouse
2002-11-19 18:21 Petr Vandrovec
2002-11-19 18:44 ` Jeff Garzik
2002-11-19 22:07 ` Rusty Russell
2002-11-19 21:49 ` Rusty Russell
2002-11-19 22:23 Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021120072654.1B6192C07A@lists.samba.org \
--to=rusty@rustcorp.com.au \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®