* [PATCH][2.4/2.5] Fix ns83820 ioctl oops
@ 2002-11-26 12:27 Roger Luethi
0 siblings, 0 replies; only message in thread
From: Roger Luethi @ 2002-11-26 12:27 UTC (permalink / raw)
To: Linus Torvalds, Marcelo Tosatti; +Cc: linux-kernel, linux-ns83820
[-- Attachment #1: Type: text/plain, Size: 188 bytes --]
Patch fixes the line mistaking a null pointer for an actual reference.
Also, to prevent this from happening again, the null pointer now is
replaced with the real one. Please apply.
Roger
[-- Attachment #2: ns83820.c.diff --]
[-- Type: text/plain, Size: 692 bytes --]
--- drivers/net/ns83820.c.orig Wed Nov 20 12:51:37 2002
+++ drivers/net/ns83820.c Tue Nov 26 12:51:39 2002
@@ -1214,7 +1214,7 @@ static int ns83820_ethtool_ioctl (struct
static int ns83820_ioctl(struct net_device *_dev, struct ifreq *rq, int cmd)
{
- struct ns83820 *dev = _dev->priv;
+ struct ns83820 *dev = (struct ns83820 *)_dev;
switch(cmd) {
case SIOCETHTOOL:
@@ -1788,6 +1788,7 @@ static int __devinit ns83820_init_one(st
dev->ee.cache = &dev->MEAR_cache;
dev->ee.lock = &dev->misc_lock;
dev->net_dev.owner = THIS_MODULE;
+ dev->net_dev.priv = dev;
PREPARE_TQUEUE(&dev->tq_refill, queue_refill, dev);
tasklet_init(&dev->rx_tasklet, rx_action, (unsigned long)dev);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2002-11-26 12:20 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-11-26 12:27 [PATCH][2.4/2.5] Fix ns83820 ioctl oops Roger Luethi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®