mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* Trivial patch: linux-2.5.50/fs/read_write.c contained unnecessary assignment in do_readv_writev
@ 2002-11-30 19:43 Adam J. Richter
  0 siblings, 0 replies; only message in thread
From: Adam J. Richter @ 2002-11-30 19:43 UTC (permalink / raw)
  To: viro; +Cc: linux-kernel

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]

Hi Al,

	I'm not sure if you are the right person to send this
to.  If there is a more appropriate person to send this patch
to, feel free to redirect me.

	The following patch deletes an unncessary assignment
in do_readv_writev.  I've widened the patch context to make it
clear that the assignment was being overwritten immediately,
regardless of the result of the "if" statement that follows it.

	If this patch looks OK, can you please forward it to Linus?
If you'd rather I send this down some other path to Linus, please let
me know.

-- 
Adam J. Richter     __     ______________   575 Oroville Road
adam@yggdrasil.com     \ /                  Milpitas, California 95035
+1 408 309-6081         | g g d r a s i l   United States of America
                         "Free Software For The Rest Of Us."

[-- Attachment #2: diff --]
[-- Type: text/plain, Size: 543 bytes --]

--- linux-2.5.50/fs/read_write.c	2002-11-27 14:36:14.000000000 -0800
+++ linux/fs/read_write.c	2002-11-30 11:35:14.000000000 -0800
@@ -400,15 +400,14 @@
 	/* VERIFY_WRITE actually means a read, as we write to user space */
 	ret = locks_verify_area((type == READ 
 				 ? FLOCK_VERIFY_READ : FLOCK_VERIFY_WRITE),
 				inode, file, *pos, tot_len);
 	if (ret)
 		goto out;
 
-	fnv = NULL;
 	if (type == READ) {
 		fn = file->f_op->read;
 		fnv = file->f_op->readv;
 	} else {
 		fn = (io_fn_t)file->f_op->write;
 		fnv = file->f_op->writev;
 	}

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2002-11-30 19:36 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-11-30 19:43 Trivial patch: linux-2.5.50/fs/read_write.c contained unnecessary assignment in do_readv_writev Adam J. Richter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®