From: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: mj@ucw.cz, linux-kernel@vger.kernel.org, mochel@osdl.org
Subject: Re: [BKPATCH] allow pci primary peer busses to have parents
Date: Thu, 5 Dec 2002 16:12:05 +0300 [thread overview]
Message-ID: <20021205161205.A6419@jurassic.park.msu.ru> (raw)
In-Reply-To: <200212041718.gB4HIO702869@localhost.localdomain>; from James.Bottomley@SteelEye.com on Wed, Dec 04, 2002 at 11:18:24AM -0600
On Wed, Dec 04, 2002 at 11:18:24AM -0600, James Bottomley wrote:
> Now that the generic device model allows a coherent bus tree to be built
Unfortunately it doesn't. Currently those legacy, PnP, EISA devices all have
virtual parents, which has nothing to do with reality. Modern systems
(including most PCs) hang these buses off PCI bus using PCI-to-{E}ISA
bridge. Such systems must be able to register these buses upon
discovery of the ISA bridges (from pci layer), and use them as a
parent device for legacy/isa/pnp stuff. This will be absolutely required
if DMA operations are moved from pci_dev to the generic device.
> -struct pci_bus * __devinit pci_scan_bus(int bus, struct pci_ops *ops, void
> *sysdata)
> +struct pci_bus * __devinit pci_scan_bus_parented(struct device *parent, int
> bus, struct pci_ops *ops, void *sysdata)
> {
> - struct pci_bus *b = pci_alloc_primary_bus(bus);
> + struct pci_bus *b = pci_alloc_primary_bus_parented(parent, bus);
> if (b) {
> b->sysdata = sysdata;
> b->ops = ops;
The `sysdata' arg already contains info about parent host-to-pci controller
on many platforms. I don't think that we need to duplicate it with
another one.
I was thinking about something like this instead of `sysdata':
struct io_controller { /* Level 0 I/O controller */
... arch specific fields ...;
... generic fields ...; /* like `index' */
struct device dev;
}
Ivan.
next prev parent reply other threads:[~2002-12-05 13:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-04 17:18 James Bottomley
2002-12-05 13:12 ` Ivan Kokshaysky [this message]
2002-12-05 15:33 ` James Bottomley
2002-12-05 17:19 ` Ivan Kokshaysky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021205161205.A6419@jurassic.park.msu.ru \
--to=ink@jurassic.park.msu.ru \
--cc=James.Bottomley@SteelEye.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mj@ucw.cz \
--cc=mochel@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®