From: Adrian Bunk <bunk@fs.tum.de>
To: Linus Torvalds <torvalds@transmeta.com>, Christoph Hellwig <hch@lst.de>
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>, will@cs.earlham.edu
Subject: Re: Linux v2.5.54
Date: Thu, 2 Jan 2003 16:08:40 +0100 [thread overview]
Message-ID: <20030102150839.GN6114@fs.tum.de> (raw)
In-Reply-To: <Pine.LNX.4.44.0301011935410.8506-100000@penguin.transmeta.com>
On Wed, Jan 01, 2003 at 07:43:40PM -0800, Linus Torvalds wrote:
>...
> Summary of changes from v2.5.53 to v2.5.54
> ============================================
>...
> Christoph Hellwig <hch@lst.de>:
>...
> o include <linux/vfs.h> only in files actually needing it
>...
This change broke the compilation of fs/befs/linuxvfs.c:
<-- snip -->
...
gcc -Wp,-MD,fs/befs/.linuxvfs.o.d -D__KERNEL__ -Iinclude -Wall
-Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common -pipe
-mpreferred-stack-boundary=2 -march=k6 -Iinclude/asm-i386/mach-default -nostdinc
-iwithprefix include -DKBUILD_BASENAME=linuxvfs -DKBUILD_MODNAME=befs -c -o
fs/befs/linuxvfs.o fs/befs/linuxvfs.c
fs/befs/linuxvfs.c:15: linux/statfs.h: No such file or directory
...
fs/befs/linuxvfs.c: In function `befs_statfs':
fs/befs/linuxvfs.c:901: dereferencing pointer to incomplete type
fs/befs/linuxvfs.c:902: dereferencing pointer to incomplete type
fs/befs/linuxvfs.c:903: dereferencing pointer to incomplete type
...
make[2]: *** [fs/befs/linuxvfs.o] Error 1
make[1]: *** [fs/befs] Error 2
make: *** [fs] Error 2
<-- snip -->
I assume the following was intended?
--- linux-2.5.54/fs/befs/linuxvfs.c.old 2003-01-02 16:03:34.000000000 +0100
+++ linux-2.5.54/fs/befs/linuxvfs.c 2003-01-02 16:03:46.000000000 +0100
@@ -12,7 +12,7 @@
#include <linux/stat.h>
#include <linux/nls.h>
#include <linux/buffer_head.h>
-#include <linux/statfs.h>
+#include <linux/vfs.h>
#include "befs.h"
#include "btree.h"
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2003-01-02 15:00 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-02 3:43 Linus Torvalds
2003-01-02 4:38 ` William Lee Irwin III
2003-01-02 10:43 ` Rusty Russell
2003-01-02 10:55 ` Andi Kleen
2003-01-02 11:13 ` William Lee Irwin III
2003-01-02 4:52 ` Linux v2.5.54 - OHCI-HCD build fails Murray J. Root
2003-01-02 5:00 ` Murray J. Root
2003-01-02 5:16 ` [PATCH] " Andres Salomon
2003-01-02 5:43 ` Murray J. Root
2003-01-02 6:10 ` Andres Salomon
2003-01-02 10:34 ` Linux v2.5.54 SZALAY Attila
2003-01-02 15:50 ` Randy.Dunlap
2003-01-02 15:56 ` Randy.Dunlap
2003-01-03 9:32 ` SZALAY Attila
2003-01-03 11:04 ` SZALAY Attila
2003-01-03 12:19 ` Alan Cox
2003-01-03 12:44 ` Christoph Hellwig
2003-01-03 16:13 ` Randy.Dunlap
2003-01-02 15:08 ` Adrian Bunk [this message]
2003-01-02 15:10 ` Christoph Hellwig
2003-01-02 17:18 ` Adrian Bunk
2003-01-02 17:31 ` Jaroslav Kysela
2003-01-02 13:26 ` Adam Belay
2003-01-03 0:08 ` [2.5.54] OOPS: unable to handle kernel paging request Steven Barnhart
2003-01-03 6:49 ` Paul Rolland
2003-01-02 17:49 ` Linux v2.5.54 Rudmer van Dijk
2003-01-02 23:48 ` [OOPS] Linux v2.5.54 Riva Framebuffer Udo A. Steinberg
2003-01-04 21:13 ` James Simmons
2003-01-02 14:42 Linux v2.5.54 Paolo Ciarrocchi
2003-01-04 10:20 ` Kasper Dupont
2003-01-04 11:47 Paolo Ciarrocchi
2003-01-04 12:27 ` Kasper Dupont
2003-01-04 14:06 Paolo Ciarrocchi
2003-01-04 14:19 ` Kasper Dupont
2003-01-04 17:10 Paolo Ciarrocchi
2003-01-04 18:14 Paolo Ciarrocchi
2003-01-04 22:14 ` Kasper Dupont
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030102150839.GN6114@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=will@cs.earlham.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®