mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Andres Salomon" <dilinger@voxel.net>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] Re: Linux v2.5.54 - OHCI-HCD build fails
Date: Thu, 02 Jan 2003 00:16:33 -0500	[thread overview]
Message-ID: <pan.2003.01.02.05.16.23.282892@voxel.net> (raw)
In-Reply-To: <20030102050007.GB1464@Master.Wizards>

This fixes it.  data0 and data1 are defined inside a DEBUG #ifdef context,
and used outside of it.
 
On Thu, 02 Jan 2003 00:00:07 -0500, Murray J. Root wrote:

> On Wed, Jan 01, 2003 at 11:52:45PM -0500, Murray J. Root wrote:
>> On Wed, Jan 01, 2003 at 07:43:40PM -0800, Linus Torvalds wrote:
>> > 
>> > Happy new year to you all, hopefully most of you are back from the dead 
>> > and the hangovers are all long gone.  And if not, I'm told reading a large 
>> > kernel patch is _just_ the medication for whatever ails you.
>> > 
>> > The 2.5.54 patch is largely mainly a big collection of various small
>> > things, all over the place (diffstat shows a long list of small changes,
>> > with some noticeable activity in UML, the MPT fusion driver and some of
>> > the fbcon drivers).
>> > 
>> > Various module updates (deprecated functions, updated loaders etc), usb, 
>> > m68k, x86-64 updates, kbuild stuff etc etc.
>> 
>> Build error:
>> 
>> In file included from drivers/usb/host/ohci-hcd.c:137:
>> drivers/usb/host/ohci-dbg.c: In function `show_list':
>> drivers/usb/host/ohci-dbg.c:358: `data1' undeclared (first use in this function)
>> drivers/usb/host/ohci-dbg.c:358: (Each undeclared identifier is reported only once
>> drivers/usb/host/ohci-dbg.c:358: for each function it appears in.)
>> drivers/usb/host/ohci-dbg.c:358: `data0' undeclared (first use in this function)
>> make[3]: *** [drivers/usb/host/ohci-hcd.o] Error 1
>> 
> 
> checking "USB verbose debug nessages" lets it build
> not what I wanted, but better than no ohci-hcd



--- a/drivers/usb/host/ohci-dbg.c	2003-01-02 00:06:40.000000000 -0500
+++ b/drivers/usb/host/ohci-dbg.c	2003-01-02 00:09:22.000000000 -0500
@@ -9,9 +9,7 @@
  */
  
 /*-------------------------------------------------------------------------*/
-static const char data0 [] = "DATA0";
-static const char data1 [] = "DATA1";
-
+ 
 #ifdef DEBUG
 
 #define edstring(ed_type) ({ char *temp; \
@@ -218,6 +216,9 @@
 	ohci_dump_roothub (controller, 1);
 }
 
+static const char data0 [] = "DATA0";
+static const char data1 [] = "DATA1";
+
 static void ohci_dump_td (char *label, struct td *td)
 {
 	u32	tmp = le32_to_cpup (&td->hwINFO);




  reply	other threads:[~2003-01-02  5:12 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-02  3:43 Linux v2.5.54 Linus Torvalds
2003-01-02  4:38 ` William Lee Irwin III
2003-01-02 10:43   ` Rusty Russell
2003-01-02 10:55     ` Andi Kleen
2003-01-02 11:13       ` William Lee Irwin III
2003-01-02  4:52 ` Linux v2.5.54 - OHCI-HCD build fails Murray J. Root
2003-01-02  5:00   ` Murray J. Root
2003-01-02  5:16     ` Andres Salomon [this message]
2003-01-02  5:43       ` [PATCH] " Murray J. Root
2003-01-02  6:10         ` Andres Salomon
2003-01-02 10:34 ` Linux v2.5.54 SZALAY Attila
2003-01-02 15:50   ` Randy.Dunlap
2003-01-02 15:56     ` Randy.Dunlap
2003-01-03  9:32     ` SZALAY Attila
2003-01-03 11:04       ` SZALAY Attila
2003-01-03 12:19         ` Alan Cox
2003-01-03 12:44           ` Christoph Hellwig
2003-01-03 16:13       ` Randy.Dunlap
2003-01-02 15:08 ` Adrian Bunk
2003-01-02 15:10   ` Christoph Hellwig
2003-01-02 17:18 ` Adrian Bunk
2003-01-02 17:31   ` Jaroslav Kysela
2003-01-02 13:26     ` Adam Belay
2003-01-03  0:08       ` [2.5.54] OOPS: unable to handle kernel paging request Steven Barnhart
2003-01-03  6:49         ` Paul Rolland
2003-01-02 17:49 ` Linux v2.5.54 Rudmer van Dijk
2003-01-02 23:48 ` [OOPS] Linux v2.5.54 Riva Framebuffer Udo A. Steinberg
2003-01-04 21:13   ` James Simmons

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=pan.2003.01.02.05.16.23.282892@voxel.net \
    --to=dilinger@voxel.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®