mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Christoph Hellwig <hch@infradead.org>,
	Linus Torvalds <torvalds@transmeta.com>,
	Christoph Hellwig <hch@lst.de>,
	linux-kernel@vger.kernel.org,
	Kai Germaschewski <kai@tp1.ruhr-uni-bochum.de>
Subject: Re: [PATCH] more procfs bits for !CONFIG_MMU
Date: Thu, 2 Jan 2003 17:29:56 +0100	[thread overview]
Message-ID: <20030102162956.GB956@mars.ravnborg.org> (raw)
In-Reply-To: <20030101235842.A3044@infradead.org>

On Wed, Jan 01, 2003 at 11:58:42PM +0000, Christoph Hellwig wrote:
> > Isn't it much nicer to just write this something like
> > 
> > 	proc-mmu-y = proc_mmu.o
> > 	proc-mmu-n = proc_nommu.o
> > 
> > 	obj-y += $(proc-mmu-$(CONFIG_MMU))
> > 
> > instead, and avoid conditionals?
> 
> Could be done.  Maybe Kai even has an even nicer generic version? :)
Here's my try:
Old makefile:
proc-objs    := inode.o root.o base.o generic.o array.o \
                kmsg.o proc_tty.o proc_misc.o kcore.o

ifeq ($(CONFIG_PROC_DEVICETREE),y)
proc-objs    += proc_devtree.o
endif

New Makefile:
proc-y             := proc_mmu.o
proc-$(CONFIG_MMU) := proc_nommu.o

proc-y += inode.o root.o base.o generic.o array.o \
          kmsg.o proc_tty.o proc_misc.o kcore.o

proc-$(CONFIG_PROC_DEVICETREE) += proc_devtree.o

Untested...

	Sam

  parent reply	other threads:[~2003-01-02 16:21 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-01-01 23:05 Christoph Hellwig
2003-01-01 23:43 ` Linus Torvalds
2003-01-01 23:58   ` Christoph Hellwig
2003-01-02  0:32     ` Linus Torvalds
2003-01-02 16:29     ` Sam Ravnborg [this message]
2003-01-02 16:35       ` Christoph Hellwig
2003-01-02 16:49         ` Sam Ravnborg
2003-01-02 16:51           ` Christoph Hellwig
2003-01-15 16:11   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030102162956.GB956@mars.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=hch@infradead.org \
    --cc=hch@lst.de \
    --cc=kai@tp1.ruhr-uni-bochum.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®