* [PATCH 2.5] Stop APM as module from oopsing
@ 2003-01-04 21:15 Daniel Ritz
2003-01-06 4:18 ` Linus Torvalds
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Ritz @ 2003-01-04 21:15 UTC (permalink / raw)
To: Linus Torvalds, Linux-Kernel
trivial fix to stop APM from oopsing when compiled as module.
against 2.5.54bk1. please apply.
beep
-daniel
--- 2554-clean/arch/i386/kernel/apm.c 2003-01-03 17:00:54.000000000 +0100
+++ 2554/arch/i386/kernel/apm.c 2003-01-04 21:31:50.000000000 +0100
@@ -718,7 +718,7 @@
* same format.
*/
-static int __init apm_driver_version(u_short *val)
+static int apm_driver_version(u_short *val)
{
u32 eax;
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH 2.5] Stop APM as module from oopsing
2003-01-04 21:15 [PATCH 2.5] Stop APM as module from oopsing Daniel Ritz
@ 2003-01-06 4:18 ` Linus Torvalds
0 siblings, 0 replies; 2+ messages in thread
From: Linus Torvalds @ 2003-01-06 4:18 UTC (permalink / raw)
To: Daniel Ritz; +Cc: Linux-Kernel
On Sat, 4 Jan 2003, Daniel Ritz wrote:
>
> trivial fix to stop APM from oopsing when compiled as module.
> against 2.5.54bk1. please apply.
Hmm.. I think this is potentially a bug even for non-modular builds, since
apm_driver_version() is called from the APM thread, and as such it might
in theory (although probably not in practice) run after the init sequence
even when compiled in.
Applied, with modified checkin comments.
Linus
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-01-06 4:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-01-04 21:15 [PATCH 2.5] Stop APM as module from oopsing Daniel Ritz
2003-01-06 4:18 ` Linus Torvalds
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®