[BK SUMMARY] remove 32 group limit (re-send)

[BK SUMMARY] remove 32 group limit (re-send)

[Timothy Hockin]

Linus,

I've sent this a bunch of times.  I don't know if it is just getting dropped
or if there is some reason you don't want it in.  Could you please either
explain why it will never go in or what needs to be fixed for it to go in?

This patch removes the hard NGROUPS limit.  It has been in use in a similar
form on our systems for some time.  I've sent it several times, and it has
evolved a lot from the original form.  I've had no complaints from anyone
about this version of the patch.

There is a small change needed for glibc, and I will send that patch to the
glibc people when this gets pulled.

Unlike some prior versions of this patch, I have changed qsort() to a simple
non-recursive sort.  Several people indicated that this change would solve
their objections.  I have also changed the behavior of sys_setgroups to use an
inline array of gid_t for small sets of groups.  Larger sets of groups use
kmalloc, and very large sets use vmalloc.  This has turned up a big speed
increase for the (admittedly stupid) test of setgroups() in a loop with random
data and sets of 1-32 items, repeated hundreds of thousands of times, as well
as the tests of setgroups with random set sizes between 1 and 10000.

Lastly, this does not fixup all the architectures.  I have or will soon have
other patchsets for that, which need to be reviewed by arch maintainers.

Tim




Please do a

	bk pull http://suncobalt.bkbits.net/ngroups-2.5

This will update the following files:

 fs/nfsd/auth.c                 |   11 +--
 fs/proc/array.c                |    2 
 include/asm-i386/param.h       |    4 -
 include/linux/init_task.h      |    1 
 include/linux/kernel.h         |    3 
 include/linux/limits.h         |    3 
 include/linux/sched.h          |    6 +
 include/linux/sunrpc/svcauth.h |    3 
 kernel/exit.c                  |    7 +
 kernel/fork.c                  |    7 +
 kernel/sys.c                   |  145 ++++++++++++++++++++++++++++++++++-------
 kernel/uid16.c                 |   64 +++++++++++++-----
 lib/Makefile                   |    4 -
 lib/bsearch.c                  |   49 +++++++++++++
 net/sunrpc/svcauth_unix.c      |    4 -
 15 files changed, 257 insertions(+), 56 deletions(-)

through these ChangeSets (diffs in separate email):

<thockin@freakshow.cobalt.com> (02/12/16 1.888)
   Remove the limit of 32 groups.  We now have a per-task, dynamic array of
   groups, which is kept sorted and refcounted.  If the task has less than 32 
   groups, we behave like older kernels and use an inline array.
   
   This ChangeSet incorporates all the core functionality. but does not fixup
   all the incorrect architecture usages of groups.  That will follow.

Re: [BK SUMMARY] remove 32 group limit (re-send)

[Remco Post]

On Mon, 6 Jan 2003 15:29:34 -0800 (PST)
Timothy Hockin <th122948@scl2.sfbay.sun.com> wrote:

> Linus,
> 
> I've sent this a bunch of times.  I don't know if it is just getting
> dropped or if there is some reason you don't want it in.  Could you please
> either explain why it will never go in or what needs to be fixed for it to
> go in?
> 
> This patch removes the hard NGROUPS limit.  It has been in use in a
> similar form on our systems for some time.  I've sent it several times,
> and it has evolved a lot from the original form.  I've had no complaints
> from anyone about this version of the patch.

Wasn't there something about groups and NFS? I remember configuring solaris
once to allow for more than 32 groups for a single user, and NFS for those
users that we in more than 32 groups would break horribly. Granted, one
should not use NFS, if it can be avoided, nor is it reasonable to impose NFS
limitations on environments that don't use NFS, still, I think it's a good
thing to ehh, maybe have to enable the use of more than 32 groups in some
/proc file....

Oh btw. In none of our current environments, we actually run into this 32
group limit, not even in the really big ones.....

-- 
Met vriendelijke groeten,

Remco Post

SARA - Stichting Academisch Rekencentrum Amsterdam    http://www.sara.nl
High Performance Computing  Tel. +31 20 592 8008    Fax. +31 20 668 3167

"I really didn't foresee the Internet. But then, neither did the computer
industry. Not that that tells us very much of course - the computer industry
didn't even foresee that the century was going to end." -- Douglas Adams