From: James Bottomley <James.Bottomley@steeleye.com>
To: Kai Germaschewski <kai@tp1.ruhr-uni-bochum.de>
Cc: linux-kernel@vger.kernel.org, James.Bottomley@SteelEye.com
Subject: [PATCH] fix broken kallsyms on non-x86 archs
Date: Sun, 12 Jan 2003 13:40:22 -0500 [thread overview]
Message-ID: <200301121840.h0CIeMd11612@localhost.localdomain> (raw)
[-- Attachment #1: Type: text/plain, Size: 332 bytes --]
kallsyms is broken in parisc on 2.5.56 again because of assembler syntax
subtleties. This is the offending line:
printf("\t.byte 0x%02x ; .asciz\t\"%s\"\n"
Note the `;' separating the two statements. On some platforms `;' is a
comment in assembly code, and thus the following .asciz is ignored. The fix
is attached.
James
[-- Attachment #2: tmp.diff --]
[-- Type: text/plain , Size: 445 bytes --]
===== scripts/kallsyms.c 1.6 vs edited =====
--- 1.6/scripts/kallsyms.c Thu Jan 2 04:02:18 2003
+++ edited/scripts/kallsyms.c Sun Jan 12 12:23:03 2003
@@ -144,7 +144,7 @@
for (k = 0; table[i].sym[k] && table[i].sym[k] == prev[k]; ++k)
;
- printf("\t.byte 0x%02x ; .asciz\t\"%s\"\n", k, table[i].sym + k);
+ printf("\t.byte 0x%02x\n\t.asciz\t\"%s\"\n", k, table[i].sym + k);
last_addr = table[i].addr;
prev = table[i].sym;
}
reply other threads:[~2003-01-12 18:31 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200301121840.h0CIeMd11612@localhost.localdomain \
--to=james.bottomley@steeleye.com \
--cc=kai@tp1.ruhr-uni-bochum.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®