* [PATCH] fix broken kallsyms on non-x86 archs
@ 2003-01-12 18:40 James Bottomley
0 siblings, 0 replies; only message in thread
From: James Bottomley @ 2003-01-12 18:40 UTC (permalink / raw)
To: Kai Germaschewski; +Cc: linux-kernel, James.Bottomley
[-- Attachment #1: Type: text/plain, Size: 332 bytes --]
kallsyms is broken in parisc on 2.5.56 again because of assembler syntax
subtleties. This is the offending line:
printf("\t.byte 0x%02x ; .asciz\t\"%s\"\n"
Note the `;' separating the two statements. On some platforms `;' is a
comment in assembly code, and thus the following .asciz is ignored. The fix
is attached.
James
[-- Attachment #2: tmp.diff --]
[-- Type: text/plain , Size: 445 bytes --]
===== scripts/kallsyms.c 1.6 vs edited =====
--- 1.6/scripts/kallsyms.c Thu Jan 2 04:02:18 2003
+++ edited/scripts/kallsyms.c Sun Jan 12 12:23:03 2003
@@ -144,7 +144,7 @@
for (k = 0; table[i].sym[k] && table[i].sym[k] == prev[k]; ++k)
;
- printf("\t.byte 0x%02x ; .asciz\t\"%s\"\n", k, table[i].sym + k);
+ printf("\t.byte 0x%02x\n\t.asciz\t\"%s\"\n", k, table[i].sym + k);
last_addr = table[i].addr;
prev = table[i].sym;
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2003-01-12 18:31 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-01-12 18:40 [PATCH] fix broken kallsyms on non-x86 archs James Bottomley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®