From: Rusty Russell <rusty@rustcorp.com.au>
To: Frank Davis <fdavis@si.rr.com>
Cc: linux-kernel@vger.kernel.org
Subject: re: smctr patch (with no subect)
Date: Mon, 10 Feb 2003 11:20:02 +1100 [thread overview]
Message-ID: <20030210014640.D2DD72C078@lists.samba.org> (raw)
In-Reply-To: Your message of "Fri, 07 Feb 2003 12:05:28 CDT." <Pine.LNX.4.44.0302071204270.6917-100000@master>
In message <Pine.LNX.4.44.0302071204270.6917-100000@master> you write:
> Hello all,
> The following patch addresses buzilla bug # 312, and removes an
> offending semicolon. Please review for inclusion.
>
> Regards,
> Frank
>
> --- linux/drivers/net/tokenring/smctr.c.old 2003-01-16 21:22:09.000000000 -
0500
> +++ linux/drivers/net/tokenring/smctr.c 2003-02-07 03:10:50.000000000 -
0500
> @@ -3064,7 +3064,7 @@
> __u8 r;
>
> /* Check if node address has been specified by user. (non-0) */
> - for(i = 0; ((i < 6) && (dev->dev_addr[i] == 0)); i++);
> + for(i = 0; ((i < 6) && (dev->dev_addr[i] == 0)); i++)
> {
> if(i != 6)
> {
NAK, I believe this is the way the code is supposed to work.
Of course, opening a new block after the for is completely gratuitous
and designed to fool the reader.
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
prev parent reply other threads:[~2003-02-10 1:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-07 17:05 Frank Davis
2003-02-10 0:20 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030210014640.D2DD72C078@lists.samba.org \
--to=rusty@rustcorp.com.au \
--cc=fdavis@si.rr.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®