* (no subject)
@ 2003-02-07 17:05 Frank Davis
2003-02-10 0:20 ` smctr patch (with no subect) Rusty Russell
0 siblings, 1 reply; 2+ messages in thread
From: Frank Davis @ 2003-02-07 17:05 UTC (permalink / raw)
To: linux-kernel; +Cc: fdavis, trivial
Hello all,
The following patch addresses buzilla bug # 312, and removes an
offending semicolon. Please review for inclusion.
Regards,
Frank
--- linux/drivers/net/tokenring/smctr.c.old 2003-01-16 21:22:09.000000000 -0500
+++ linux/drivers/net/tokenring/smctr.c 2003-02-07 03:10:50.000000000 -0500
@@ -3064,7 +3064,7 @@
__u8 r;
/* Check if node address has been specified by user. (non-0) */
- for(i = 0; ((i < 6) && (dev->dev_addr[i] == 0)); i++);
+ for(i = 0; ((i < 6) && (dev->dev_addr[i] == 0)); i++)
{
if(i != 6)
{
^ permalink raw reply [flat|nested] 2+ messages in thread* re: smctr patch (with no subect)
2003-02-07 17:05 Frank Davis
@ 2003-02-10 0:20 ` Rusty Russell
0 siblings, 0 replies; 2+ messages in thread
From: Rusty Russell @ 2003-02-10 0:20 UTC (permalink / raw)
To: Frank Davis; +Cc: linux-kernel
In message <Pine.LNX.4.44.0302071204270.6917-100000@master> you write:
> Hello all,
> The following patch addresses buzilla bug # 312, and removes an
> offending semicolon. Please review for inclusion.
>
> Regards,
> Frank
>
> --- linux/drivers/net/tokenring/smctr.c.old 2003-01-16 21:22:09.000000000 -
0500
> +++ linux/drivers/net/tokenring/smctr.c 2003-02-07 03:10:50.000000000 -
0500
> @@ -3064,7 +3064,7 @@
> __u8 r;
>
> /* Check if node address has been specified by user. (non-0) */
> - for(i = 0; ((i < 6) && (dev->dev_addr[i] == 0)); i++);
> + for(i = 0; ((i < 6) && (dev->dev_addr[i] == 0)); i++)
> {
> if(i != 6)
> {
NAK, I believe this is the way the code is supposed to work.
Of course, opening a new block after the for is completely gratuitous
and designed to fool the reader.
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-02-10 1:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-02-07 17:05 Frank Davis
2003-02-10 0:20 ` smctr patch (with no subect) Rusty Russell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®