From: Rusty Russell <rusty@rustcorp.com.au>
To: Frank Davis <fdavis@si.rr.com>
Cc: linux-kernel@vger.kernel.org, Hai-Pao Fan <haipao@mvista.com>,
source@mvista.com
Subject: Re: [PATCH] 2.5.59 : drivers/char/ite_gpio.c
Date: Mon, 10 Feb 2003 11:29:30 +1100 [thread overview]
Message-ID: <20030210014641.02ABE2C09B@lists.samba.org> (raw)
In-Reply-To: Your message of "Fri, 07 Feb 2003 12:19:51 CDT." <Pine.LNX.4.44.0302071217520.6917-100000@master>
In message <Pine.LNX.4.44.0302071217520.6917-100000@master> you write:
> --- linux/drivers/char/ite_gpio.c.old 2003-01-16 21:22:23.000000000 -0500
> +++ linux/drivers/char/ite_gpio.c 2003-02-07 02:04:43.000000000 -0500
> @@ -140,7 +140,7 @@
> {
> int ret=-1;
>
> - if (MAX_GPIO_LINE > *data >= 0)
> + if ((MAX_GPIO_LINE > *data) && (*data >= 0))
> ret=ite_gpio_irq_pending[*data];
>
> DEB(printk("ite_gpio_in_status %d ret=%d\n",*data, ret));
Nope, of course *data is >= 0, it's a u32.
Once again, the author needs to indicate (and test!) what was meant
here...
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
next prev parent reply other threads:[~2003-02-10 1:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-07 17:19 Frank Davis
2003-02-10 0:29 ` Rusty Russell [this message]
2003-02-10 10:13 ` Horst von Brand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030210014641.02ABE2C09B@lists.samba.org \
--to=rusty@rustcorp.com.au \
--cc=fdavis@si.rr.com \
--cc=haipao@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=source@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®