* [PATCH] 2.5.59 : drivers/char/ite_gpio.c
@ 2003-02-07 17:19 Frank Davis
2003-02-10 0:29 ` Rusty Russell
0 siblings, 1 reply; 3+ messages in thread
From: Frank Davis @ 2003-02-07 17:19 UTC (permalink / raw)
To: linux-kernel; +Cc: fdavis, trivial
Hello all,
The following patch addresses buzilla bug # 321, and removes a double
logical issue. Please review for inclusion.
Regards,
Frank
--- linux/drivers/char/ite_gpio.c.old 2003-01-16 21:22:23.000000000 -0500
+++ linux/drivers/char/ite_gpio.c 2003-02-07 02:04:43.000000000 -0500
@@ -140,7 +140,7 @@
{
int ret=-1;
- if (MAX_GPIO_LINE > *data >= 0)
+ if ((MAX_GPIO_LINE > *data) && (*data >= 0))
ret=ite_gpio_irq_pending[*data];
DEB(printk("ite_gpio_in_status %d ret=%d\n",*data, ret));
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] 2.5.59 : drivers/char/ite_gpio.c
2003-02-07 17:19 [PATCH] 2.5.59 : drivers/char/ite_gpio.c Frank Davis
@ 2003-02-10 0:29 ` Rusty Russell
2003-02-10 10:13 ` Horst von Brand
0 siblings, 1 reply; 3+ messages in thread
From: Rusty Russell @ 2003-02-10 0:29 UTC (permalink / raw)
To: Frank Davis; +Cc: linux-kernel, Hai-Pao Fan, source
In message <Pine.LNX.4.44.0302071217520.6917-100000@master> you write:
> --- linux/drivers/char/ite_gpio.c.old 2003-01-16 21:22:23.000000000 -0500
> +++ linux/drivers/char/ite_gpio.c 2003-02-07 02:04:43.000000000 -0500
> @@ -140,7 +140,7 @@
> {
> int ret=-1;
>
> - if (MAX_GPIO_LINE > *data >= 0)
> + if ((MAX_GPIO_LINE > *data) && (*data >= 0))
> ret=ite_gpio_irq_pending[*data];
>
> DEB(printk("ite_gpio_in_status %d ret=%d\n",*data, ret));
Nope, of course *data is >= 0, it's a u32.
Once again, the author needs to indicate (and test!) what was meant
here...
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] 2.5.59 : drivers/char/ite_gpio.c
2003-02-10 0:29 ` Rusty Russell
@ 2003-02-10 10:13 ` Horst von Brand
0 siblings, 0 replies; 3+ messages in thread
From: Horst von Brand @ 2003-02-10 10:13 UTC (permalink / raw)
To: Rusty Russell; +Cc: Frank Davis, linux-kernel, Hai-Pao Fan, source
Rusty Russell <rusty@rustcorp.com.au> said:
> In message <Pine.LNX.4.44.0302071217520.6917-100000@master> you write:
> > --- linux/drivers/char/ite_gpio.c.old 2003-01-16 21:22:23.000000000 -0500
> > +++ linux/drivers/char/ite_gpio.c 2003-02-07 02:04:43.000000000 -0500
> > @@ -140,7 +140,7 @@
> > {
> > int ret=-1;
> >
> > - if (MAX_GPIO_LINE > *data >= 0)
> > + if ((MAX_GPIO_LINE > *data) && (*data >= 0))
> > ret=ite_gpio_irq_pending[*data];
> >
> > DEB(printk("ite_gpio_in_status %d ret=%d\n",*data, ret));
>
> Nope, of course *data is >= 0, it's a u32.
MAX_GPIO_LINE > *data >= 0 is (MAX_GPIO_LINE > *data) >= 0 is (0 or 1) >= 0
is 1 ;-)
--
Dr. Horst H. von Brand User #22616 counter.li.org
Departamento de Informatica Fono: +56 32 654431
Universidad Tecnica Federico Santa Maria +56 32 654239
Casilla 110-V, Valparaiso, Chile Fax: +56 32 797513
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2003-02-10 10:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-02-07 17:19 [PATCH] 2.5.59 : drivers/char/ite_gpio.c Frank Davis
2003-02-10 0:29 ` Rusty Russell
2003-02-10 10:13 ` Horst von Brand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®