RE: [PATCHSET] PC-9800 subarch. support for 2.5.60 (12/34) consol e

RE: [PATCHSET] PC-9800 subarch. support for 2.5.60 (12/34) consol e

[Osamu Tomita]

Thanks for the comments.

-----Original Message-----
From: Christoph Hellwig
To: Osamu Tomita; jsimmons@infradead.org
Cc: Linux Kernel Mailing List; Alan Cox
Sent: 2003/02/13 0:36
Subject: Re: [PATCHSET] PC-9800 subarch. support for 2.5.60 (12/34) console

> On Wed, Feb 12, 2003 at 10:42:33PM +0900, Osamu Tomita wrote:
>> +ifneq ($(CONFIG_X86_PC9800),y)
>>  FONTMAPFILE = cp437.uni
>> +else
>> +FONTMAPFILE = pc9800.uni
>> +endif
> 
> This should be
> 
> ifeq ($(CONFIG_X86_PC9800),y)
> FONTMAPFILE = pc9800.uni
> else
> FONTMAPFILE = cp437.uni
> endif
I see. I'll fix it.

> but I really wonder whether there's something nicer possible
We need pc9800.uni to display japanese "KANA" letters.
I want another nice idea too.

>> diff -Nru linux/drivers/char/console_macros.h
> Bah, console_macros.h should just die.
Thanks for the information.

>> diff -Nru linux/drivers/char/console_pc9800.h
> I think this should all be in include/linux/console.h.
I'm planning to use console_pc9800.h for PC-9800 specific macoros.
I'm testing it on 2.4.20.

>> --- linux/drivers/char/vt.c	2002-12-16 11:08:16.000000000 +0900
>> +++ linux98/drivers/char/vt.c	2002-12-20 14:52:06.000000000 +0900
>> @@ -75,6 +75,9 @@
>>   */
>>  
>>  #include <linux/module.h>
>> +#ifdef CONFIG_X86_PC9800
>> +#define CONFIG_KANJI
>> +#endif
> 
> Please set CONFIG_KANJI in the Kconfig file and in general
> the CONFIG_KANJI usere look really messy.  I don't think it's
> easy to get them cleaned up before 2.6, you might get in contact
> with James who works on the console layer to properly integrate them.
I think too, CONFIG_KANJI needs cleanup.

Regards,
Osamu Tomita

Re: [PATCHSET] PC-9800 subarch. support for 2.5.60 (12/34) consol e

['Christoph Hellwig ']

On Fri, Feb 14, 2003 at 11:50:09AM +0900, Osamu Tomita wrote:
> > Please set CONFIG_KANJI in the Kconfig file and in general
> > the CONFIG_KANJI usere look really messy.  I don't think it's
> > easy to get them cleaned up before 2.6, you might get in contact
> > with James who works on the console layer to properly integrate them.
> I think too, CONFIG_KANJI needs cleanup.

I think the major point here is:  PC98 support does have a fair chance
to get into 2.6 (with a little bit more work).  Kanji console support
certainly won't go in.  Maybe you'll remove Kanji support for the
patchkit submitted for inclusion - this will make reviewing the rest
easier.

RE: [PATCHSET] PC-9800 subarch. support for 2.5.60 (12/34) consol e

[Osamu Tomita]

-----Original Message-----
From: 'Christoph Hellwig '
To: Osamu Tomita
Cc: 'jsimmons@infradead.org '; 'Linux Kernel Mailing List '; 'Alan Cox '
Sent: 2003/02/14 14:52
Subject: Re: [PATCHSET] PC-9800 subarch. support for 2.5.60 (12/34) console

> On Fri, Feb 14, 2003 at 11:50:09AM +0900, Osamu Tomita wrote:
>> > Please set CONFIG_KANJI in the Kconfig file and in general
>> > the CONFIG_KANJI usere look really messy.  I don't think it's
>> > easy to get them cleaned up before 2.6, you might get in contact
>> > with James who works on the console layer to properly integrate
them.
>> I think too, CONFIG_KANJI needs cleanup.
> 
> I think the major point here is:  PC98 support does have a fair chance
> to get into 2.6 (with a little bit more work).  Kanji console support
> certainly won't go in.  Maybe you'll remove Kanji support for the
> patchkit submitted for inclusion - this will make reviewing the rest
> easier.
PC98 patch without CONFIG_KANJI works. I had tested already.
If 2.6 supports PC98 by removing kanji support, I think it's better.

Thanks,
Osamu Tomita