mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] aicasm Makefile
@ 2003-02-18 13:04 Bob_Tracy(0000)
  0 siblings, 0 replies; only message in thread
From: Bob_Tracy(0000) @ 2003-02-18 13:04 UTC (permalink / raw)
  To: gibbs; +Cc: linux-kernel, torvalds

[-- Attachment #1: Type: text/plain, Size: 672 bytes --]

The Makefile for aicasm has been broken since 2.5.48.  The order in
which objects are specified on the linker command line *is* significant,
and if "-ldb" is made part of AICASM_CFLAGS rather than appearing after
the "-o $(PROG)", I get an undefined symbol error (__db185_open).

The attached patch is against 2.5.54-2.5.62 inclusive.  If anyone is
wondering, yes, this is a repeat posting on this subject (original was
1 December 2002).

-- 
-----------------------------------------------------------------------
Bob Tracy                   WTO + WIPO = DMCA? http://www.anti-dmca.org
rct@frus.com
-----------------------------------------------------------------------

[-- Attachment #2: patch62_aicasm --]
[-- Type: text/plain, Size: 716 bytes --]

--- linux/drivers/scsi/aic7xxx/aicasm/Makefile~	2002-12-24 07:09:29.000000000 -0600
+++ linux/drivers/scsi/aic7xxx/aicasm/Makefile	2003-01-07 16:47:01.000000000 -0600
@@ -10,9 +10,10 @@
 GENSRCS=	$(YSRCS:.y=.c) $(LSRCS:.l=.c)
 
 SRCS=	${CSRCS} ${GENSRCS}
+LIBS=	-ldb
 CLEANFILES= ${GENSRCS} ${GENHDRS} $(YSRCS:.y=.output)
 # Override default kernel CFLAGS.  This is a userland app.
-AICASM_CFLAGS:= -I/usr/include -I. -ldb
+AICASM_CFLAGS:= -I/usr/include -I.
 YFLAGS= -d
 
 NOMAN=	noman
@@ -30,7 +31,7 @@
 endif
 
 $(PROG):  ${GENHDRS} $(SRCS)
-	$(AICASM_CC) $(AICASM_CFLAGS) $(SRCS) -o $(PROG)
+	$(AICASM_CC) $(AICASM_CFLAGS) $(SRCS) -o $(PROG) $(LIBS)
 
 aicdb.h:
 	@if [ -e "/usr/include/db3/db_185.h" ]; then		\

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2003-02-18 12:55 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-02-18 13:04 [PATCH] aicasm Makefile Bob_Tracy(0000)

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®