[PATCH 2.4.21-pre4|BK] remove /proc/meminfo:MemShared

[PATCH 2.4.21-pre4|BK] remove /proc/meminfo:MemShared

[Marc-Christian Petersen]

[-- Attachment #1: Type: text/plain, Size: 223 bytes --]

Hi Marcelo,

it seems to have been displaying zero for the past several years.

Same as in 2.5, by AKPM.

See here: 
http://linux.bkbits.net:8080/linux-2.5/cset@1.838.103.37?nav=index.html|ChangeSet@-8w

ciao, Marc

[-- Attachment #2: memshared-remove.patch --]
[-- Type: text/x-diff, Size: 618 bytes --]

--- a/fs/proc/proc_misc.c	2003-02-19 13:29:12.000000000 +0100
+++ b/fs/proc/proc_misc.c	2003-02-19 13:30:01.000000000 +0100
@@ -180,7 +180,6 @@ static int meminfo_read_proc(char *page,
 	len += sprintf(page+len,
 		"MemTotal:     %8lu kB\n"
 		"MemFree:      %8lu kB\n"
-		"MemShared:    %8lu kB\n"
 		"Buffers:      %8lu kB\n"
 		"Cached:       %8lu kB\n"
 		"SwapCached:   %8lu kB\n"
@@ -194,7 +193,6 @@ static int meminfo_read_proc(char *page,
 		"SwapFree:     %8lu kB\n",
 		K(i.totalram),
 		K(i.freeram),
-		K(i.sharedram),
 		K(i.bufferram),
 		K(pg_size - swapper_space.nrpages),
 		K(swapper_space.nrpages),

Re: [PATCH 2.4.21-pre4|BK] remove /proc/meminfo:MemShared

[Adrian Bunk]

On Wed, Feb 19, 2003 at 01:42:34PM +0100, Marc-Christian Petersen wrote:

> Hi Marcelo,

Hi Marc,

> it seems to have been displaying zero for the past several years.
> 
> Same as in 2.5, by AKPM.
>...

I don't think it's good to do this change in a stable kernel series. The 
entry doesn't do any harm and there might be programs that parse 
/proc/meminfo and expect MemShared to be present.

> ciao, Marc

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

Re: [PATCH 2.4.21-pre4|BK] remove /proc/meminfo:MemShared

[Marc-Christian Petersen]

On Wednesday 19 February 2003 14:00, Adrian Bunk wrote:

Hi Adrian,

> I don't think it's good to do this change in a stable kernel series. The
> entry doesn't do any harm and there might be programs that parse
> /proc/meminfo and expect MemShared to be present.
well, I am not aware of any program that needs MemShared.

This is also in my WOLK tree for a long time (even longer than it was in 2.5) 
and no one out there complained about it yet :)

ciao, Marc

Re: [PATCH 2.4.21-pre4|BK] remove /proc/meminfo:MemShared

[Alan Cox]

On Wed, 2003-02-19 at 12:42, Marc-Christian Petersen wrote:
> Hi Marcelo,
> 
> it seems to have been displaying zero for the past several years.

It was left in because some tools break if you remove it. For 2.5 its
much less of an issue.