From: Andrew Morton <akpm@digeo.com>
To: James Harper <james.harper@bigpond.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: PATCH to fix irq sharing and SA_INTERRUPT on x86. please review
Date: Mon, 24 Feb 2003 03:09:16 -0800 [thread overview]
Message-ID: <20030224030916.632dd876.akpm@digeo.com> (raw)
In-Reply-To: <3E59F611.3020206@bigpond.com>
James Harper <james.harper@bigpond.com> wrote:
>
> further to my email yesterday (to which i've had no response :) i
> propose the attached patch to arch/i386/kernel/irq.c. it corrects what i
> see as a bug in interrupt handling.
>
> currently if a driver requests SA_INTERRUPT in an interrupt handler, it
> is only called with interrupts disabled if it is the first handler in
> the list.
ewww..
> my patch modifies setup_irq to put any interrupt with SA_INTERRUPT in
> the front of the handler queue (eg before any handlers without the flag).
>
> and also modifies handle_IRQ_event to only enable interrupts when it
> hits the first handler with SA_INTERRUPT not set.
>
Yes, that's a nice fix, thanks.
Other architectures appear to have inherited this bug.
prev parent reply other threads:[~2003-02-24 10:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-24 10:38 James Harper
2003-02-24 11:09 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030224030916.632dd876.akpm@digeo.com \
--to=akpm@digeo.com \
--cc=james.harper@bigpond.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®