mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Oliver Neukum <oliver@neukum.name>
To: Duncan Sands <baldrick@wanadoo.fr>,
	linux-usb-devel@lists.sourceforge.net
Cc: Greg KH <greg@kroah.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB speedtouch: better proc info
Date: Mon, 24 Feb 2003 11:43:20 +0100	[thread overview]
Message-ID: <200302241143.20632.oliver@neukum.name> (raw)
In-Reply-To: <200302241058.52073.baldrick@wanadoo.fr>

Am Montag, 24. Februar 2003 10:58 schrieb Duncan Sands:
> Output the correct device name, show the state of the device (for
> debugging) and of the ADSL line (anyone want to write a graphical utility
> to show this, like under windows?).  We no longer consult the usb_device
> struct in udsl_atm_proc_read, so don't take a reference to it.  Against
> Greg's current 2.5 USB tree.

First of all, let me say that you're doing wonders with this driver.
But this particular patch I don't like. It improves stuff that should
be removed. More specifically:

1. Does anything prevent you from using the medium detection
hooks the network layer provides?
2. What need is there to export manufacturer id and mac address
again?
3. Doesn't the rest belong into sysfs rather than procfs?

	Regards
		Oliver


  reply	other threads:[~2003-02-24 13:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-02-24  9:58 Duncan Sands
2003-02-24 10:43 ` Oliver Neukum [this message]
2003-02-25  8:22   ` Duncan Sands
2003-02-25 20:54     ` Oliver Neukum
2003-02-26  7:31       ` Duncan Sands

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200302241143.20632.oliver@neukum.name \
    --to=oliver@neukum.name \
    --cc=baldrick@wanadoo.fr \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®