* mem= option for broken bioses
@ 2003-02-26 20:38 Pavel Machek
0 siblings, 0 replies; 6+ messages in thread
From: Pavel Machek @ 2003-02-26 20:38 UTC (permalink / raw)
To: ACPI mailing list, kernel list, Andrew Grover
Hi!
I've seen broken bios that did not mark acpi tables in e820
tables. This allows user to override it. Please apply,
Pavel
--- linux/arch/i386/kernel/setup.c 2003-02-11 17:50:57.000000000 +0100
+++ linux-tablet/arch/i386/kernel/setup.c 2003-02-20 18:03:03.000000000 +0100
@@ -546,6 +546,12 @@
if (*from == '@') {
start_at = memparse(from+1, &from);
add_memory_region(start_at, mem_size, E820_RAM);
+ } else if (*from == '#') {
+ start_at = memparse(from+1, &from);
+ add_memory_region(start_at, mem_size, E820_ACPI);
+ } else if (*from == '$') {
+ start_at = memparse(from+1, &from);
+ add_memory_region(start_at, mem_size, E820_RESERVED);
} else {
limit_regions(mem_size);
userdef=1;
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: mem= option for broken bioses
2003-03-04 13:18 ` Pavel Machek
@ 2003-03-04 14:21 ` H. Peter Anvin
0 siblings, 0 replies; 6+ messages in thread
From: H. Peter Anvin @ 2003-03-04 14:21 UTC (permalink / raw)
To: Pavel Machek; +Cc: linux-kernel
Pavel Machek wrote:
>
> This should be commented, somewhere.
It's commented in Documentation/i386/boot.txt as well as the
kernel-options file. *ALL* i386 boot loaders need to obey this,
unfortunately, because of how the initrd protocol was defined.
> Why is mem= option used by boot loader?
> Does your bootloader really parse stuff
> like mem=exactmap?
No, and that's exactly the problem. A whole bunch of crap was added to
mem= retroactively (over my explicit objections), and that broke the
boot protocol.
-hpa
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: mem= option for broken bioses
[not found] ` <b3m840_5e4_1@cesium.transmeta.com>
@ 2003-03-04 13:18 ` Pavel Machek
2003-03-04 14:21 ` H. Peter Anvin
0 siblings, 1 reply; 6+ messages in thread
From: Pavel Machek @ 2003-03-04 13:18 UTC (permalink / raw)
To: H. Peter Anvin; +Cc: linux-kernel
Hi!
> > > I've seen broken bios that did not mark acpi tables in e820
> > > tables. This allows user to override it. Please apply,
> >
> > OK, looks reasonable. Can you also gen up a patch documenting this in
> > kernel-parameters.txt?
> >
>
> This is very much *NOT* reasonable. In fact, screwing around with the
> syntax of the mem= parameter is poison. I know it has already
> happened, and those changes need to be reverted and the new stuff
> moved to a different option.
>
> The mem= option is unique in that it is an option that affects both
> the boot loader and the kernel. Therefore, ITS SYNTAX MUST NOT
> CHANGE.
This should be commented, somewhere.
Why is mem= option used by boot loader?
Does your bootloader really parse stuff
like mem=exactmap?
--
Pavel
Written on sharp zaurus, because my Velo1 broke. If you have Velo you don't need...
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: mem= option for broken bioses
2003-02-26 22:39 Grover, Andrew
2003-02-26 22:44 ` Pavel Machek
@ 2003-02-27 23:48 ` H. Peter Anvin
[not found] ` <b3m840_5e4_1@cesium.transmeta.com>
2 siblings, 0 replies; 6+ messages in thread
From: H. Peter Anvin @ 2003-02-27 23:48 UTC (permalink / raw)
To: linux-kernel
Followup to: <F760B14C9561B941B89469F59BA3A8471380D7@orsmsx401.jf.intel.com>
By author: "Grover, Andrew" <andrew.grover@intel.com>
In newsgroup: linux.dev.kernel
>
> > From: Pavel Machek [mailto:pavel@ucw.cz]
> > I've seen broken bios that did not mark acpi tables in e820
> > tables. This allows user to override it. Please apply,
>
> OK, looks reasonable. Can you also gen up a patch documenting this in
> kernel-parameters.txt?
>
This is very much *NOT* reasonable. In fact, screwing around with the
syntax of the mem= parameter is poison. I know it has already
happened, and those changes need to be reverted and the new stuff
moved to a different option.
The mem= option is unique in that it is an option that affects both
the boot loader and the kernel. Therefore, ITS SYNTAX MUST NOT
CHANGE.
-hpa
--
<hpa@transmeta.com> at work, <hpa@zytor.com> in private!
"Unix gives you enough rope to shoot yourself in the foot."
Architectures needed: cris ia64 m68k mips64 ppc ppc64 s390 s390x sh v850 x86-64
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: mem= option for broken bioses
2003-02-26 22:39 Grover, Andrew
@ 2003-02-26 22:44 ` Pavel Machek
2003-02-27 23:48 ` H. Peter Anvin
[not found] ` <b3m840_5e4_1@cesium.transmeta.com>
2 siblings, 0 replies; 6+ messages in thread
From: Pavel Machek @ 2003-02-26 22:44 UTC (permalink / raw)
To: Grover, Andrew; +Cc: ACPI mailing list, kernel list
Hi!
> > From: Pavel Machek [mailto:pavel@ucw.cz]
> > I've seen broken bios that did not mark acpi tables in e820
> > tables. This allows user to override it. Please apply,
>
> OK, looks reasonable. Can you also gen up a patch documenting this in
> kernel-parameters.txt?
You can, assuming you took the patch ;-).
Pavel
--- clean/Documentation/kernel-parameters.txt 2003-02-11 17:40:28.000000000 +0100
+++ linux/Documentation/kernel-parameters.txt 2003-02-26 23:43:21.000000000 +0100
@@ -516,6 +516,10 @@
[KNL,BOOT] Force usage of a specific region of memory
Region of memory to be used, from ss to ss+nn.
+ mem=nn[KMG]#ss[KMG]
+ [KNL,BOOT,ACPI] Mark specific memory as ACPI data.
+ Region of memory to be used, from ss to ss+nn.
+
mem=nopentium [BUGS=IA-32] Disable usage of 4MB pages for kernel
memory.
--
Horseback riding is like software...
...vgf orggre jura vgf serr.
^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: mem= option for broken bioses
@ 2003-02-26 22:39 Grover, Andrew
2003-02-26 22:44 ` Pavel Machek
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Grover, Andrew @ 2003-02-26 22:39 UTC (permalink / raw)
To: Pavel Machek, ACPI mailing list, kernel list
> From: Pavel Machek [mailto:pavel@ucw.cz]
> I've seen broken bios that did not mark acpi tables in e820
> tables. This allows user to override it. Please apply,
OK, looks reasonable. Can you also gen up a patch documenting this in
kernel-parameters.txt?
Thanks -- Regards -- Andy
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2003-03-04 14:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-02-26 20:38 mem= option for broken bioses Pavel Machek
2003-02-26 22:39 Grover, Andrew
2003-02-26 22:44 ` Pavel Machek
2003-02-27 23:48 ` H. Peter Anvin
[not found] ` <b3m840_5e4_1@cesium.transmeta.com>
2003-03-04 13:18 ` Pavel Machek
2003-03-04 14:21 ` H. Peter Anvin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®