[PATCH] Fix scsi_probe_and_add_lun

[PATCH] Fix scsi_probe_and_add_lun

[Marc Zyngier]

[-- Attachment #1: Type: text/plain, Size: 226 bytes --]

Christoph,

The following patch fixes a bug introduced in the recent scsi_scan.c
reorganisation.

Without this patch, my Alpha Jensen was crashing just after detecting
its first SCSI disk. It is now working fine.

        M.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: jensen.patch --]
[-- Type: text/x-patch, Size: 933 bytes --]

# This is a BitKeeper generated patch for the following project:
# Project Name: Linux kernel tree
# This patch format is intended for GNU patch command version 2.5 or higher.
# This patch includes the following deltas:
#	           ChangeSet	1.1092  -> 1.1093 
#	drivers/scsi/scsi_scan.c	1.62    -> 1.63   
#
# The following is the BitKeeper ChangeSet Log
# --------------------------------------------
# 03/02/28	maz@hina.wild-wind.fr.eu.org	1.1093
# Fix scsi_probe_and_add_lun typo.
# The ol'Jensen wouldn't boot without it...
# --------------------------------------------
#
diff -Nru a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
--- a/drivers/scsi/scsi_scan.c	Fri Feb 28 20:45:00 2003
+++ b/drivers/scsi/scsi_scan.c	Fri Feb 28 20:45:00 2003
@@ -1338,7 +1338,7 @@
 	scsi_release_request(sreq);
  out_free_sdev:
 	if (res == SCSI_SCAN_LUN_PRESENT) {
-		if (*sdevp)
+		if (sdevp)
 			*sdevp = sdev;
 	} else {
 		if (q) {

[-- Attachment #3: Type: text/plain, Size: 59 bytes --]


-- 
Places change, faces change. Life is so very strange.

Re: [PATCH] Fix scsi_probe_and_add_lun

[Christoph Hellwig]

On Fri, Feb 28, 2003 at 08:48:07PM +0100, Marc Zyngier wrote:
> Christoph,
> 
> The following patch fixes a bug introduced in the recent scsi_scan.c
> reorganisation.
> 
> Without this patch, my Alpha Jensen was crashing just after detecting
> its first SCSI disk. It is now working fine.

Argg, stupid mistake - thanks for the patch.