From: Andrew Morton <akpm@digeo.com>
To: vda@port.imtp.ilyichevsk.odessa.ua
Cc: joe@tmsusa.com, linux-kernel@vger.kernel.org
Subject: Re: Oops in 2.5.64
Date: Thu, 6 Mar 2003 00:14:57 -0800 [thread overview]
Message-ID: <20030306001457.7537e37a.akpm@digeo.com> (raw)
In-Reply-To: <200303060749.h267nPu01086@Port.imtp.ilyichevsk.odessa.ua>
Denis Vlasenko <vda@port.imtp.ilyichevsk.odessa.ua> wrote:
>
> > Eh? How come the compiler didn't inline
> > __constant_c_and_count_memset? What compiler version are you using?
>
> ...
>
> +/* GCC 3 (and probably earlier, I'm not sure) can be told to always inline
> + a function. */
> +#if __GNUC__ < 3
> +#define force_inline inline
> +#else
> +#define force_inline inline __attribute__ ((always_inline))
> +#endif
Well I'd consider this a workaround for a rampant compiler bug. It's just
weird that it refuses to inline a function like that. Having to make 10,000
edits to the kernel tree to work around this does not appeal.
Cannot we just stick:
#define inline __inline__ __attribute__((always_inline))
in kernel.h?
next prev parent reply other threads:[~2003-03-06 8:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-06 6:15 J Sloan
2003-03-06 6:36 ` Andrew Morton
2003-03-06 7:17 ` bert hubert
2003-03-06 7:36 ` J Sloan
2003-03-06 7:46 ` Denis Vlasenko
2003-03-06 8:14 ` Andrew Morton [this message]
2003-03-06 11:59 ` Ingo Oeser
2003-03-06 19:36 ` Linus Torvalds
2003-03-06 19:53 ` J Sloan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030306001457.7537e37a.akpm@digeo.com \
--to=akpm@digeo.com \
--cc=joe@tmsusa.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vda@port.imtp.ilyichevsk.odessa.ua \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®