mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Oeser <ingo.oeser@informatik.tu-chemnitz.de>
To: Andrew Morton <akpm@digeo.com>
Cc: vda@port.imtp.ilyichevsk.odessa.ua, joe@tmsusa.com,
	linux-kernel@vger.kernel.org
Subject: Re: Oops in 2.5.64
Date: Thu, 6 Mar 2003 12:59:07 +0100	[thread overview]
Message-ID: <20030306125907.S629@nightmaster.csn.tu-chemnitz.de> (raw)
In-Reply-To: <20030306001457.7537e37a.akpm@digeo.com>; from akpm@digeo.com on Thu, Mar 06, 2003 at 12:14:57AM -0800

Hi,

On Thu, Mar 06, 2003 at 12:14:57AM -0800, Andrew Morton wrote:
> Cannot we just stick:
> 
> 	#define inline	__inline__ __attribute__((always_inline))
> 
> in kernel.h?

I second this, because that's how we actually use this keyword in
the kernel. We don't mean "please inline, if you can" but
actually "inline it, or I'll force you harder!".

It doesn't look like at first glance, but it actually is the
cleanest solution for recent GCCs.

Even better would be a "-Winline-limit=X" to warn for the cases,
where we should review the tradeoff.

Regards

Ingo Oeser
-- 
Marketing ist die Kunst, Leuten Sachen zu verkaufen, die sie
nicht brauchen, mit Geld, was sie nicht haben, um Leute zu
beeindrucken, die sie nicht moegen.

  reply	other threads:[~2003-03-06 11:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-03-06  6:15 J Sloan
2003-03-06  6:36 ` Andrew Morton
2003-03-06  7:17   ` bert hubert
2003-03-06  7:36   ` J Sloan
2003-03-06  7:46   ` Denis Vlasenko
2003-03-06  8:14     ` Andrew Morton
2003-03-06 11:59       ` Ingo Oeser [this message]
2003-03-06 19:36 ` Linus Torvalds
2003-03-06 19:53   ` J Sloan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030306125907.S629@nightmaster.csn.tu-chemnitz.de \
    --to=ingo.oeser@informatik.tu-chemnitz.de \
    --cc=akpm@digeo.com \
    --cc=joe@tmsusa.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vda@port.imtp.ilyichevsk.odessa.ua \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®