From: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: linux-kernel@vger.kernel.org
Subject: [patch 2.5] PCI: pbus_size_mem() fix
Date: Wed, 12 Mar 2003 20:04:59 +0300 [thread overview]
Message-ID: <20030312200459.A6570@jurassic.park.msu.ru> (raw)
This fixes long standing typo ('size' instead of 'r_size') which causes
overestimate of the bridge memory ranges calculated in pbus_size_mem().
For example, if we have a device with one 1Mb and one 2Mb memory ranges
behind the bridge, calculated size and alignment of the bridge memory
window will be 4Mb and 2Mb respectively, while the correct values are
3Mb and 1Mb.
Ivan.
--- 2.5/drivers/pci/setup-bus.c Wed Mar 12 13:33:45 2003
+++ linux/drivers/pci/setup-bus.c Wed Mar 12 18:50:03 2003
@@ -284,7 +284,7 @@ pbus_size_mem(struct pci_bus *bus, unsig
order = 0;
/* Exclude ranges with size > align from
calculation of the alignment. */
- if (size == align)
+ if (r_size == align)
aligns[order] += align;
if (order > max_order)
max_order = order;
reply other threads:[~2003-03-12 16:54 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030312200459.A6570@jurassic.park.msu.ru \
--to=ink@jurassic.park.msu.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®