mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [patch 2.5] PCI: pbus_size_mem() fix
@ 2003-03-12 17:04 Ivan Kokshaysky
  0 siblings, 0 replies; only message in thread
From: Ivan Kokshaysky @ 2003-03-12 17:04 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel

This fixes long standing typo ('size' instead of 'r_size') which causes
overestimate of the bridge memory ranges calculated in pbus_size_mem().
For example, if we have a device with one 1Mb and one 2Mb memory ranges
behind the bridge, calculated size and alignment of the bridge memory
window will be 4Mb and 2Mb respectively, while the correct values are
3Mb and 1Mb.

Ivan.

--- 2.5/drivers/pci/setup-bus.c	Wed Mar 12 13:33:45 2003
+++ linux/drivers/pci/setup-bus.c	Wed Mar 12 18:50:03 2003
@@ -284,7 +284,7 @@ pbus_size_mem(struct pci_bus *bus, unsig
 				order = 0;
 			/* Exclude ranges with size > align from
 			   calculation of the alignment. */
-			if (size == align)
+			if (r_size == align)
 				aligns[order] += align;
 			if (order > max_order)
 				max_order = order;

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2003-03-12 16:54 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-03-12 17:04 [patch 2.5] PCI: pbus_size_mem() fix Ivan Kokshaysky

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®