[PATCH][kconfig][i386] Fix help entry for processor type choice

[PATCH][kconfig][i386] Fix help entry for processor type choice

[Petr Baudis]

  Hello,

  this patch (against 2.5.64) moves the generic help of the "Processor family"
choice from the CONFIG_M386 option, adding some specific information about i386
processors to it instead.

  Please consider applying.

 arch/i386/Kconfig |   17 ++++++++++++-----
 1 files changed, 12 insertions(+), 5 deletions(-)

  Kind regards,
				Petr Baudis

--- linux+pasky/arch/i386/Kconfig	Thu Mar  6 20:38:49 2003
+++ linux/arch/i386/Kconfig	Sat Mar 15 21:34:16 2003
@@ -110,10 +110,7 @@
 choice
 	prompt "Processor family"
 	default M686
-
-config M386
-	bool "386"
-	---help---
+	help
 	  This is the processor type of your CPU. This information is used for
 	  optimizing purposes. In order to compile a kernel that can run on
 	  all x86 CPU types (albeit not optimally fast), you can specify
@@ -148,10 +145,20 @@
 
 	  If you don't know what to do, choose "386".
 
+config M386
+	bool "386"
+	help
+	  Select this for an x386 processor, that is AMD/Cyrix/Intel
+	  386DX/DXL/SL/SLC/SX, Cyrix/TI 486DLC/DLC2, UMC 486SX-S and NexGen
+	  Nx586. Kernel compiled for this processor will also run on any newer
+	  processor of this architecture, although not optimally fast.
+
+	  If you don't know what processor to choose, choose this one.
+
 config M486
 	bool "486"
 	help
-	  Select this for a x486 processor, ether Intel or one of the
+	  Select this for an x486 processor, either Intel or one of the
 	  compatible processors from AMD, Cyrix, IBM, or Intel.  Includes DX,
 	  DX2, and DX4 variants; also SL/SLC/SLC2/SLC3/SX/SX2 and UMC U5D or
 	  U5S.

Re: [PATCH][kconfig][i386] Fix help entry for processor type choice

[Petr Baudis]

Dear diary, on Sat, Mar 15, 2003 at 11:13:06PM CET, I got a letter,
where Dave Jones <davej@codemonkey.org.uk> told me, that...
> On Sat, Mar 15, 2003 at 09:40:09PM +0100, Petr Baudis wrote:
> 
>  >  	bool "486"
>  >  	help
>  > -	  Select this for a x486 processor, ether Intel or one of the
>  > +	  Select this for an x486 processor, either Intel or one of the
> 
> This bit is broken. There is no x486 processor, it should be either
> 'i486', '80486' or just '486'. There's already a patch fixing up this
> (and x586 x686 etc) in Alans 2.5-ac patchset.

Ok, the new version follows, thanks. It does s/an x386/386 series/ and removes
the x486 line typo fixes, which are redundant for -ac (which is where this will
probably end up anyway).

-- 
 
				Petr "Pasky" Baudis
.
The pure and simple truth is rarely pure and never simple.
		-- Oscar Wilde
.
Stuff: http://pasky.ji.cz/

--- linux+pasky/arch/i386/Kconfig	Thu Mar  6 20:38:49 2003
+++ linux/arch/i386/Kconfig	Sat Mar 15 21:34:16 2003
@@ -110,10 +110,7 @@
 choice
 	prompt "Processor family"
 	default M686
-
-config M386
-	bool "386"
-	---help---
+	help
 	  This is the processor type of your CPU. This information is used for
 	  optimizing purposes. In order to compile a kernel that can run on
 	  all x86 CPU types (albeit not optimally fast), you can specify
@@ -148,6 +145,16 @@
 
 	  If you don't know what to do, choose "386".
 
+config M386
+	bool "386"
+	help
+	  Select this for a 386 series processor, that is AMD/Cyrix/Intel
+	  386DX/DXL/SL/SLC/SX, Cyrix/TI 486DLC/DLC2, UMC 486SX-S and NexGen
+	  Nx586. Kernel compiled for this processor will also run on any newer
+	  processor of this architecture, although not optimally fast.
+
+	  If you don't know what processor to choose, choose this one.
+
 config M486
 	bool "486"
 	help

Re: [PATCH][kconfig][i386] Fix help entry for processor type choice

[Dave Jones]

On Sat, Mar 15, 2003 at 09:40:09PM +0100, Petr Baudis wrote:

 >  	bool "486"
 >  	help
 > -	  Select this for a x486 processor, ether Intel or one of the
 > +	  Select this for an x486 processor, either Intel or one of the

This bit is broken. There is no x486 processor, it should be either
'i486', '80486' or just '486'. There's already a patch fixing up this
(and x586 x686 etc) in Alans 2.5-ac patchset.

		Dave

Re: [PATCH][kconfig][i386] Fix help entry for processor type choice

[Alan Cox]

> +	  Select this for a 386 series processor, that is AMD/Cyrix/Intel
> +	  386DX/DXL/SL/SLC/SX, Cyrix/TI 486DLC/DLC2, UMC 486SX-S and NexGen
> +	  Nx586. Kernel compiled for this processor will also run on any newer
> +	  processor of this architecture, although not optimally fast.

There are about ten other processors. Trying to list them all is going
to send people potty. Also some UMC don't work with this or any other
option. 

The list you have now looks pretty sensible as a basis.

Re: [PATCH][kconfig][i386] Fix help entry for processor type choice

[Petr Baudis]

Dear diary, on Sat, Mar 15, 2003 at 11:22:37PM CET, I got a letter,
where Alan Cox <alan@redhat.com> told me, that...
> > +	  Select this for a 386 series processor, that is AMD/Cyrix/Intel
> > +	  386DX/DXL/SL/SLC/SX, Cyrix/TI 486DLC/DLC2, UMC 486SX-S and NexGen
> > +	  Nx586. Kernel compiled for this processor will also run on any newer
> > +	  processor of this architecture, although not optimally fast.
> 
> There are about ten other processors. Trying to list them all is going
> to send people potty. Also some UMC don't work with this or any other
> option. 
> 
> The list you have now looks pretty sensible as a basis.

I just copied these from the original CONFIG_M386 help (now the common
"Processor type" help).

-- 
 
				Petr "Pasky" Baudis
.
The pure and simple truth is rarely pure and never simple.
		-- Oscar Wilde
.
Stuff: http://pasky.ji.cz/