* i2c_inc/dec_use_client in 2.5.x?
@ 2003-03-21 15:57 Ronald Bultje
2003-03-21 16:08 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Ronald Bultje @ 2003-03-21 15:57 UTC (permalink / raw)
To: linux-kernel
Hey,
what happened to above-mentioned functions? Well, yes, I can see that
they're removed in 2.5.65 (probably earlier, I can't find them in any
2.5.x version), but why? Aren't the i2c client modules supposed to keep
their use count dynamically anymore? i2c_client->inc/dec_use are gone
too...
I had a short look at the saa7111 file (drivers/media/video/saa7111.c),
and it seems to keep use count in the attach/detach callbacks. Is this
the way to go? In the documentation (probably from 2.4.x), developers
were told this was stupid (Documentation/i2c/writing-clients). What's
the current 'policy'?
Thanks,
Ronald
(please CC, I'm not subscribed)
--
Ronald Bultje <rbultje@ronald.bitfreak.net>
Linux Video/Multimedia developer
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: i2c_inc/dec_use_client in 2.5.x?
2003-03-21 15:57 i2c_inc/dec_use_client in 2.5.x? Ronald Bultje
@ 2003-03-21 16:08 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2003-03-21 16:08 UTC (permalink / raw)
To: Ronald Bultje; +Cc: linux-kernel
On Fri, Mar 21, 2003 at 04:57:44PM +0100, Ronald Bultje wrote:
> Hey,
>
> what happened to above-mentioned functions? Well, yes, I can see that
> they're removed in 2.5.65 (probably earlier, I can't find them in any
> 2.5.x version), but why? Aren't the i2c client modules supposed to keep
> their use count dynamically anymore? i2c_client->inc/dec_use are gone
> too...
use try_module_get/module_put on ->owner.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-03-21 15:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-03-21 15:57 i2c_inc/dec_use_client in 2.5.x? Ronald Bultje
2003-03-21 16:08 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®